properties_collector: (un)materialize: add missing m_name #1213
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use highest bit of m_rows for m_name existing flag, this is safe, because m_rows is 64 bits, m_rows will never reach 64 bits limit.
…TATS_VERSION_WITH_NAME
Contributor
|
Could you elaborate more about why it is necessary to store index names in SST files? Index name is defined in MySQL data dictionary, so MyRocks can extract index names, map between internal index ids and index names when opening tables. |
Contributor
Author
|
We have an visualization tool which can view structures inside an SST file, by this tool we found name is missing, then we added name in (un)materialize.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bump stats version to
INDEX_STATS_VERSION_WITH_NAME = 3for addedm_name.