add streaming support for list_object_versions #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implemented stream_object_versions!/3 in lazy.ex to enable streaming through paginated object version results using dual-marker pagination (key_marker + version_id_marker). updated list_object_versions to support streaming via ExAws.stream!() similar to list_objects and list_objects_v2. tests now use per-test buckets to eliminate flakiness from shared state. cleanup simplified to use list_object_versions which works for both versioned and non-versioned buckets (non-versioned objects have version_id of "null"). using request!() for cleanup makes failures visible.
verifies basic streaming, pagination with uneven last page (33 versions across 7 pages with max_keys=5), and proper handling of delete markers in streams. ensures dual-marker pagination works correctly and that both versions and delete markers are returned when streaming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds streaming support to
list_object_versionsto match the existing pattern used bylist_objectsandlist_objects_v2.Changes
stream_object_versions!/3inExAws.S3.Lazywith dual-marker pagination (key_marker + version_id_marker) as required by S3 APIlist_object_versionsto supportExAws.stream!()viastream_builderoptionadd_version_results/1helper to combine versions and delete markersTests
Test isolation improved: each test now uses a unique bucket to prevent state pollution. Cleanup uses
list_object_versionswhich works for both versioned and non-versioned buckets (non-versioned objects have version_id of "null").