signer/core: prefer Input over Data for calldata display; compare effective calldata in logDiff #33081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the signer CLI and change logging with transaction semantics that prefer Input over Data
ApproveTx() now shows the effective calldata (prefer Input), and warns if both input and data are present and different.logDiff() now compares effective calldata (prefer Input) so changes to Input are detected and logged.
Added unit tests covering four scenarios: only Input, only Data, both equal, both different. Tests validate CLI output and
logDiff()’s modified result.