Skip to content

Conversation

@msimberg
Copy link
Contributor

@msimberg msimberg commented Dec 2, 2025

Test description contains more details. Related to eth-cscs/alps-uenv#277.

@jgphpc jgphpc requested a review from Copilot December 4, 2025 08:11
Copilot finished reviewing on behalf of jgphpc December 4, 2025 08:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new ReFrame test to verify that GCC in the uenv environment does not generate "fixed" versions of the pthread.h header file. This is related to a known issue with GCC's fixincludes mechanism that can cause problems in containerized environments. The test searches for pthread.h files in the uenv directories and verifies that none are located in an include-fixed directory, which would indicate unwanted GCC header "fixes".

Key changes:

  • Added new test class UenvFixincludes that checks for absence of GCC-fixed pthread.h headers
  • Test uses find command to search /user-environment and /user-tools directories
  • Validates that no pthread.h files are found in include-fixed paths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@jgphpc jgphpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed: UENV=prgenv-gnu/25.07-6.3.3:v10

/user-environment/linux-zen3/gcc-13.4.0-tnhlqoff4ydzqd43d3hewb2fdpzvrq5n/lib/gcc/x86_64-pc-linux-gnu/13.4.0/include-fixed/pthread.h

@jgphpc jgphpc merged commit 8b0bbca into eth-cscs:main Dec 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants