Skip to content

fix network scanning report (TZ-2115) #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix network scanning report (TZ-2115) #737

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33c7796
fix network scanning report
nraynaud Nov 1, 2025
e2b41bc
fix network scanning report
nraynaud Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/esp-zigbee-ncp/src/esp_ncp_zb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ static void esp_ncp_zb_bind_cb(esp_zb_zdp_status_t zdo_status, void *user_ctx)
};

typedef struct {
esp_zb_zdp_status_t zdo_status;
uint8_t zdo_status;
esp_ncp_zb_user_cb_t zdo_cb; /*!< A ZDO match desc request callback */
} ESP_NCP_ZB_PACKED_STRUCT esp_ncp_zb_bind_parameters_t;

Expand Down Expand Up @@ -291,7 +291,7 @@ static void esp_ncp_zb_zdo_scan_complete_handler(esp_zb_zdp_status_t zdo_status,
scan_data->count = count;

if (nwk_descriptor && count) {
memcpy(scan_data + sizeof(esp_ncp_zb_scan_parameters_t), nwk_descriptor, (count * sizeof(esp_zb_network_descriptor_t)));
memcpy(scan_data + 1, nwk_descriptor, (count * sizeof(esp_zb_network_descriptor_t)));
Copy link
Contributor

@lhespress lhespress Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memcpy((uint8_t *)scan_data + sizeof(esp_ncp_zb_scan_parameters_t), nwk_descriptor, (count * sizeof(esp_zb_network_descriptor_t))); is better.

Copy link
Contributor Author

@nraynaud nraynaud Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as you don't mess the base pointer, do what you want. I personally would never remember the precedence of the casting vs addition but I'm not an expert.

}

esp_ncp_noti_input(&ncp_header, output, outlen);
Expand Down