Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Nov 20, 2025

What does this implement/fix?

Update benchmarks to use Python 3.14

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome (if applicable):

  • esphome/esphome#

Checklist:

  • The code change is tested and works locally.
  • If api.proto was modified, a linked pull request has been made to esphome with the same changes.
  • Tests have been added to verify that the new code works (under tests/ folder).

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.84%. Comparing base (fa4dc53) to head (8422456).

Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1427      +/-   ##
===========================================
- Coverage   100.00%   99.84%   -0.16%     
===========================================
  Files           22       22              
  Lines         3310     3310              
===========================================
- Hits          3310     3305       -5     
- Misses           0        5       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 20, 2025

CodSpeed Performance Report

Merging #1427 will degrade performances by 7.83%

Comparing benchmarks_314 (8422456) with main (fa4dc53)

Summary

❌ 3 regressions
✅ 8 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_raw_ble_plain_text 23 µs 25 µs -7.83%
test_sending_empty_light_command_request 44.7 µs 47.7 µs -6.19%
test_sending_light_command_request_with_bool 48.3 µs 51.6 µs -6.36%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants