-
-
Notifications
You must be signed in to change notification settings - Fork 15
chore: update @eslint/core, add legacy-peer-deps, and use ESLint v10
#190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@eslint/core to v1 and add legacy-peer-deps to .npmrc
|
Hi @lumirlumir!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
@eslint/core to v1 and add legacy-peer-deps to .npmrc@eslint/core to v1 and add legacy-peer-deps
@eslint/core to v1 and add legacy-peer-deps@eslint/core, add legacy-peer-deps, and use ESLint v10 prerelease
|
Hi @lumirlumir!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
@eslint/core, add legacy-peer-deps, and use ESLint v10 prerelease@eslint/core, add legacy-peer-deps, and use ESLint v10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From ESLint v10, errors property in valid test case throws error, so I've removed it.
Ref: https://eslint.org/docs/next/use/migrate-to-10.0.0#stricter-rule-tester
|
Counterpart PR in eslint/css: eslint/css#337 |
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "@eslint/core": "^0.17.0", | ||
| "@eslint/core": "^1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a dependency, will this affect end users who are still using ESLint v9?
Prerequisites checklist
What is the purpose of this pull request?
This PR was motivated by #187 (comment).
Currently, when updating
@eslint/coreto v1.0.0, CI fails because@eslint/core@1.0.0does not match ESLint v9@eslint/core@1.0.0includes type information for ESLint v10, which causes the type mismatch.So, I've updated ESLint to
>=10.0.0-alpha.0 <10.0.0 || ^10.0.1. (Ref: https://github.com/eslint/eslint/blob/main/packages/eslint-config-eslint/package.json#L66)When I update ESLint to
>=10.0.0-alpha.0 <10.0.0 || ^10.0.1, the following error occurs, so I added thelegacy-peer-depsoption to.npmrc.This change follows the approach in eslint/eslint#20281
What changes did you make? (Give an overview)
In this PR, I've updated
@eslint/core, addlegacy-peer-deps, and use ESLint v10 pre-release.Related Issues
Ref: #187, #187 (comment), eslint/eslint#20281
Is there anything you'd like reviewers to focus on?
N/A