fix: display raw key in the message #179
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Which language are you using?
JSON, JSON5, JSONC
What did you do?
no-duplicate-keys:I expected
fo\n\u006ftto appear in the error message, but it appears asfo(newline)ot.sort-keys:I expected
bfo\n\u006ftandafo\n\u006ftto apper in the error message, but it appears asbfo(newline)otandafo(newline)ot.What did you expect to happen?
fo\n\u006ftto appear in the error message, but it appears asfo(newline)ot.bfo\n\u006ftandafo\n\u006ftto apper in the error message, but it appears asbfo(newline)otandafo(newline)ot.Link to minimal reproducible Example
The following code would help identify the problem:
What changes did you make? (Give an overview)
This PR was motivated by #151 (comment).
In this PR, I've updated the
dataproperty to show raw key values in messages instead of processed ones.The
no-duplicate-keysandsort-keysrules were mainly affected.Also, I extracted the
getKeyandgetRawKeyhelper functions intoutil.js, since they can be reused across multiple rules.Related Issues
Ref: #151 (comment)
Is there anything you'd like reviewers to focus on?
N/A