fix: correct parent typing for rule visitors

[jaymarvelz]

Prerequisites checklist

• I have read the contributing guidelines.

What is the purpose of this pull request?

To correct the JSONRuleVisitor type definitions and improve maintainability by introducing a WithExit helper (copied from eslint/markdown). This ensures :exit selectors are automatically generated for all node types and simplifies visitor type definitions.

What changes did you make? (Give an overview)

• Added a WithExit<RuleVisitorType> helper type to automatically add :exit variants.
• Replaced the manually defined JSONRuleVisitor interface with a version using WithExit.

Note on parent parameter:

The optional parent parameters were removed from all visitor methods. At runtime, these parameters always appear to be undefined. Currently, only this plugin and the eslint/markdown plugin use parent parameters in their visitors — the eslint/css plugin does not.

I’m not entirely certain if removing them is safe for all current or future use cases, so I would like to hear opinions from @fasttime on this change.

Related Issues

Is there anything you'd like reviewers to focus on?

[fasttime]

I think it would be better to keep parent as a second parameter and adjust the ESLint logic where visitors are invoked. At the moment, visitors are always called with a single argument (the target node). See the relevant lines in the ESLint source:

• https://github.com/eslint/eslint/blob/v9.38.0/lib/linter/source-code-traverser.js#L291
• https://github.com/eslint/eslint/blob/v9.38.0/lib/linter/source-code-traverser.js#L303

But for non-JS languages the parent node is stored in step.args as a second element following the target node. So probably the invocation should look like this:

visitor.callSync(selector, ...(step.args ?? [step.target]));

[jaymarvelz]

Thanks for the clarification! I went ahead and opened a PR for this: eslint/eslint#20253

[fasttime]

For reference, passing parent as a second parameter to visitors is mentioned in the language plugin design, see https://github.com/eslint/rfcs/tree/main/designs/2022-languages#the-sourcecode-object.

[DMartens]

Same as in the other PR, please add additional test cases for this.

[DMartens]

I think this should be a shared helper from @eslint/core as all ESLint languages require it.