[AUDIO_WORKLET] clarify docs and use for renderSizeHint #25760
Conversation
| ``AudioSampleFrame``'s ``samplesPerChannel`` to get the value. | ||
| ``AudioSampleFrame``'s ``samplesPerChannel`` to get the value (and request the | ||
| preferred number of samples with ``EmscriptenWebAudioCreateAttributes``'s | ||
| ``renderSizeHint`` option). |
There was a problem hiding this comment.
Why not just remove the hardcoded 128 value here and say "callback will be invoked for each N
samples of the processed (where N is is the number of samples per channel)".
The naming here also seems strange. Why is to called samplesPerChannel when its read but renderSizeHint when its hinted. Why not samplesPerChannelHint?
There was a problem hiding this comment.
samplesPerChannel has been in the Emscripten API for about a year in prep for the web audio API changes. renderSizeHint is what the spec calls it and is now available in Chrome Canary.
I chose samplesPerChannel last year when extending the API, simply because it speaks the most to what it does and where it's accessed in the API (and having been doing this sort of thing since forever, I've never once heard anyone call it a render quantum).
I think it does make sense to change the 128, but I think it'll stay 128 for most people for a long time.
There was a problem hiding this comment.
Clarified the 128.
cwoffenden
force-pushed
the
cw-aw-tweaks-1
branch
from
7981b70 to
f509023
Compare
2 participants
Minor clarification of the docs and example.