[dylink] Fix addEmJs when parameter is indirect pointer #25740
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eagleoflqj
force-pushed
the
dylink
branch
2 times, most recently
from
bf6c07d to
c113518
Compare
kripken
reviewed
Nov 10, 2025
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Thanks! This looks right.
I believe the test for it is other.test_em_js_side_module, runnable with
./test/runner other.test_em_js_side_module
Please add a ** pointer there, to test this.
sbc100
changed the title
sbc100
reviewed
Nov 11, 2025
| js_side_func(42, "hello"); | ||
| js_side_func2("hello again"); | ||
| js_side_func_void(); | ||
| js_side_func_indirect_ptr(NULL); |
Collaborator
There was a problem hiding this comment.
Can you pass &"hello" and then print the string js_side_func_indirect_ptr?
otherwise lgtm
Member
|
Also see the failing test, an expectation needs to be updated. See instructions for that in the CI error. |
Collaborator
I think just rebase should fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the middle of porting libskk with glib, and encountered a
SyntaxError: Unexpected token '*'.Given the value of
cSig,jsArgandjsArgsin debugger view, it seems straightforward.