Skip to content

Fix(eval): Correctly handle scientific notation in expressions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix(eval): Correctly handle scientific notation in expressions #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec/eeeval_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ describe EEEval::CalcParser do
describe "#evaluate", tags: "sci_notation" do
it "Evaluate expression with minus/plus sign" do
expression = "1+4.006529739295107e-5"
expression = EEEval::CalcParser.evaluate(expression)
expression.should eq(1.0000400652973929)
result = EEEval::CalcParser.evaluate(expression)
result.should eq(1.0000400652973929)
end
end

Expand Down
2 changes: 1 addition & 1 deletion src/eeeval.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ module EEEval
unless (expression.to_f?)
evaluate_rpn(infix_to_rpn expression).value
else
convert_scinot(expression)
expression
end
end

Expand Down