fixup!: fix dialyzer issues

Author: doorgan

apps/expert/lib/expert.ex

@@ -45,7 +45,7 @@ defmodule Expert do
     state = assigns(lsp).state
     Process.send_after(self(), :default_config, :timer.seconds(5))
 
-    case State.initialize(state, request, lsp) do
+    case State.initialize(state, request) do
       {:ok, response, state} ->
         # TODO: this should be gated behind the dynamic registration in the initialization params
         registrations = registrations()
@@ -153,18 +153,20 @@ defmodule Expert do
     end
   end
 
-  def handle_info(:default_config, %State{configuration: nil} = state) do
-    Logger.warning(
-      "Did not receive workspace/didChangeConfiguration notification after 5 seconds. " <>
-        "Using default settings."
-    )
+  def handle_info(:default_config, lsp) do
+    state = assigns(lsp).state
 
-    {:ok, config} = State.default_configuration(state)
-    {:noreply, %State{state | configuration: config}}
-  end
+    if state.configuration == nil do
+      Logger.warning(
+        "Did not receive workspace/didChangeConfiguration notification after 5 seconds. " <>
+          "Using default settings."
+      )
 
-  def handle_info(:default_config, %State{} = state) do
-    {:noreply, state}
+      {:ok, config} = State.default_configuration(state)
+      {:noreply, assign(lsp, state: %State{state | configuration: config})}
+    else
+      {:noreply, lsp}
+    end
   end
 
   defp apply_to_state(%State{} = state, %{} = request_or_notification) do

apps/expert/lib/expert/configuration.ex

@@ -29,8 +29,8 @@ defmodule Expert.Configuration do
 
   @dialyzer {:nowarn_function, set_dialyzer_enabled: 2}
 
-  @spec new(Forge.uri(), map(), String.t() | nil, GenLSP.Lsp.t()) :: t
-  def new(root_uri, %Structures.ClientCapabilities{} = client_capabilities, client_name, _lsp) do
+  @spec new(Forge.uri(), map(), String.t() | nil) :: t
+  def new(root_uri, %Structures.ClientCapabilities{} = client_capabilities, client_name) do
     support = Support.new(client_capabilities)
     project = Project.new(root_uri)
 

apps/expert/lib/expert/state.ex

@@ -40,16 +40,15 @@ defmodule Expert.State do
         %__MODULE__{initialized?: false} = state,
         %Requests.Initialize{
           params: %Structures.InitializeParams{} = event
-        },
-        lsp
+        }
       ) do
     client_name =
       case event.client_info do
         %{name: name} -> name
         _ -> nil
       end
 
-    config = Configuration.new(event.root_uri, event.capabilities, client_name, lsp)
+    config = Configuration.new(event.root_uri, event.capabilities, client_name)
     new_state = %__MODULE__{state | configuration: config, initialized?: true}
     Logger.info("Starting project at uri #{config.project.root_uri}")
 

apps/expert/mix.exs

@@ -44,13 +44,14 @@ defmodule Expert.MixProject do
       Mix.Dialyzer.dependency(),
       {:elixir_sense,
        github: "elixir-lsp/elixir_sense", ref: "73ce7e0d239342fb9527d7ba567203e77dbb9b25"},
+      {:engine, path: "../engine", env: Mix.env()},
+      {:forge, path: "../forge", env: Mix.env()},
+      {:gen_lsp, github: "elixir-tools/gen_lsp", branch: "async"},
       {:jason, "~> 1.4"},
       {:logger_file_backend, "~> 0.0", only: [:dev, :prod]},
       {:patch, "~> 0.15", runtime: false, only: [:dev, :test]},
       {:path_glob, "~> 0.2"},
       {:schematic, "~> 0.2"},
-      {:engine, path: "../engine", env: Mix.env()},
-      {:gen_lsp, github: "elixir-tools/gen_lsp", branch: "async"},
       {:sourceror, "~> 1.9"}
     ]
   end