fixup!: use persistent_term instead of adding .lsp to Project

Author: doorgan

apps/engine/benchmarks/ets_bench.exs

@@ -33,7 +33,7 @@ defmodule BenchHelper do
 end
 
 cwd = __DIR__
-project = Project.new(%GenLSP.LSP{mod: :foo}, "file://#{cwd}")
+project = Project.new("file://#{cwd}")
 
 Engine.set_project(project)
 Project.ensure_workspace(project)

apps/engine/test/engine/build/state_test.exs

@@ -40,7 +40,7 @@ defmodule Engine.Build.StateTest do
 
     project_name = to_string(project_name)
     fixture_dir = Path.join(fixtures_path(), project_name)
-    project = Project.new(%GenLSP.LSP{mod: :foo}, "file://#{fixture_dir}")
+    project = Project.new("file://#{fixture_dir}")
     state = State.new(project)
 
     Engine.set_project(project)

apps/engine/test/engine/build_test.exs

@@ -35,7 +35,7 @@ defmodule Engine.BuildTest do
   def with_project(project_name) do
     project_name = to_string(project_name)
     fixture_dir = Path.join(fixtures_path(), project_name)
-    project = Project.new(%GenLSP.LSP{mod: :foo}, "file://#{fixture_dir}")
+    project = Project.new("file://#{fixture_dir}")
 
     project
     |> Project.workspace_path()

apps/engine/test/engine/plugin/runner/coordinator_test.exs

@@ -77,7 +77,7 @@ defmodule Engine.Plugin.Runner.CoordinatorTest do
     end
 
     test "works with projects" do
-      project = Project.new(%GenLSP.LSP{mod: :foo}, "file://" <> __DIR__)
+      project = Project.new("file://" <> __DIR__)
 
       Runner.diagnose(project, notifier())
 

apps/engine/test/remote_control_test.exs

@@ -24,7 +24,7 @@ defmodule EngineTest do
         [fixtures_path(), "umbrella", "apps", "first"]
         |> Path.join()
         |> Document.Path.to_uri()
-        |> then(&Project.new(%GenLSP.LSP{mod: :foo}, &1))
+        |> then(&Project.new(&1))
 
       start_project(subapp_project)
 

apps/engine/test/support/test/fixtures.ex

@@ -15,7 +15,7 @@ defmodule Engine.Test.Fixtures do
     |> Path.join()
     |> Path.expand()
     |> Forge.Document.Path.to_uri()
-    |> then(&Project.new(%GenLSP.LSP{mod: :foo}, &1))
+    |> then(&Project.new(&1))
   end
 
   def project do

apps/expert/.iex.exs

@@ -11,4 +11,4 @@ other_project =
   |> Path.join()
   |> Path.expand()
 
-project = Forge.Project.new(%GenLSP.LSP{mod: :foo}, "file://#{other_project}")
+project = Forge.Project.new("file://#{other_project}")

apps/expert/lib/expert.ex

@@ -24,6 +24,8 @@ defmodule Expert do
 
   @dialyzer {:nowarn_function, apply_to_state: 2}
 
+  def get_lsp(), do: :persistent_term.get(:expert_lsp, nil)
+
   def start_link(args) do
     Logger.debug(inspect(args))
 
@@ -35,6 +37,7 @@ defmodule Expert do
   end
 
   def init(lsp, _args) do
+    :persistent_term.put(:expert_lsp, lsp)
     {:ok, assign(lsp, state: State.new())}
   end
 

apps/expert/lib/expert/configuration.ex

@@ -30,9 +30,9 @@ defmodule Expert.Configuration do
   @dialyzer {:nowarn_function, set_dialyzer_enabled: 2}
 
   @spec new(Forge.uri(), map(), String.t() | nil, GenLSP.Lsp.t()) :: t
-  def new(root_uri, %Structures.ClientCapabilities{} = client_capabilities, client_name, lsp) do
+  def new(root_uri, %Structures.ClientCapabilities{} = client_capabilities, client_name, _lsp) do
     support = Support.new(client_capabilities)
-    project = Project.new(lsp, root_uri)
+    project = Project.new(root_uri)
 
     %__MODULE__{support: support, project: project, client_name: client_name}
     |> tap(&set/1)

apps/expert/lib/expert/iex/helpers.ex

@@ -178,7 +178,7 @@ defmodule Expert.IEx.Helpers do
 
       project_uri = "file://#{project_path}"
       # FIXME(mhanberg): unclear how we will get LSP struct here
-      Forge.Project.new(%GenLSP.LSP{mod: :foo}, project_uri)
+      Forge.Project.new(project_uri)
     end)
   end