Port Clock functions to use Duration class
#19229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/duration
branch
from
a386db9 to
112a34d
Compare
erikjohnston
force-pushed
the
erikj/duration
branch
from
112a34d to
901f1fe
Compare
anoadragon453
requested changes
Nov 28, 2025
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
Really nice readability improvements across the board!
I went through each of the conversions and they looked to be correct. Just a few things below.
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
This makes it easier to create a `Duration` instance in Rust.
erikjohnston
force-pushed
the
erikj/duration
branch
from
3f178e1 to
eb01e9e
Compare
anoadragon453
approved these changes
Dec 1, 2025
Member
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
LGTM, thanks again for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the arguments in clock functions to be
Durationand converts call sites and constants intoDuration. There are still some more functions around that should be converted (e.g.timeout_deferred), but we leave that to another PR.We also changes
.as_secs()to return a float, as the rounding broke things subtly. The only reason to keep it (its the same astimedelta.total_seconds()) is for symmetry withas_millis().Follows on from #19223
Reviewable commit-by-commit.