-
Notifications
You must be signed in to change notification settings - Fork 64
Add experimental and preliminary policy-driven session limiting when logging in OAuth 2 sessions. #5221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
1690570
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://167518e6.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-policy-driven-session-li.matrix-authentication-service-docs.pages.dev |
b6ad7a4 to
9f3d978
Compare
9f3d978 to
203bf44
Compare
203bf44 to
071830e
Compare
sandhose
reviewed
Nov 6, 2025
Member
sandhose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to assume TODO after this is mostly dealing with the compat API
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
e0d7fb9 to
08959fa
Compare
sandhose
approved these changes
Nov 24, 2025
Member
sandhose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks sensible now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #4339
Intended for commit-by-commit review.
Introduces a soft and hard session limit. At login time, we count the user's existing sessions (OAuth 2, Compat and self-owned Personal) and refuse creation of a new one if the limit is reached. This is configurable by policy.
The soft limit will be used for interactive logins where the user could be shown a web UI to remove devices, whereas the hard limit will be used for
m.login.passwordlogins where the user can't be shown such a UI.Limitations:
These limitations will be handled in future PRs, but for now this is part of the experimental config section.