Skip to content

Logging geoip download failures due to node shutdown at INFO level #137772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

Logging geoip download failures due to node shutdown at INFO level #137772

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6943d9a
Logging geoip download failures due to node shutdown at INFO level
masseyke Nov 7, 2025
a80c7c1
merging main
masseyke Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion modules/ingest-geoip/src/main/java/org/elasticsearch/ingest/geoip/GeoIpDownloader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

package org.elasticsearch.ingest.geoip;

import org.apache.logging.log4j.Level;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.elasticsearch.action.ActionListener;
Expand All @@ -24,6 +25,7 @@
import org.elasticsearch.common.settings.Setting;
import org.elasticsearch.common.settings.Setting.Property;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.common.util.concurrent.EsRejectedExecutionException;
import org.elasticsearch.core.TimeValue;
import org.elasticsearch.core.Tuple;
import org.elasticsearch.index.query.BoolQueryBuilder;
Expand All @@ -33,6 +35,7 @@
import org.elasticsearch.index.reindex.DeleteByQueryRequest;
import org.elasticsearch.ingest.geoip.GeoIpTaskState.Metadata;
import org.elasticsearch.ingest.geoip.stats.GeoIpDownloaderStats;
import org.elasticsearch.node.NodeClosedException;
import org.elasticsearch.persistent.PersistentTasksCustomMetadata.PersistentTask;
import org.elasticsearch.tasks.TaskId;
import org.elasticsearch.threadpool.ThreadPool;
Expand Down Expand Up @@ -209,7 +212,13 @@ private void processDatabase(final String name, final String md5, final String u
}
} catch (Exception e) {
stats = stats.failedDownload();
logger.error(() -> "error downloading geoip database [" + name + "] for project [" + projectId + "]", e);
boolean nodeShuttingDown = e instanceof NodeClosedException
|| (e instanceof EsRejectedExecutionException rejected && rejected.isExecutorShutdown());
logger.log(
nodeShuttingDown ? Level.INFO : Level.ERROR,
() -> "error downloading geoip database [" + name + "] for project [" + projectId + "]",
e
);
}
}

Expand Down