Skip to content

Disable throttling for snapshot builds #137757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Disable throttling for snapshot builds #137757

wants to merge 2 commits into from

Conversation

@benwtrent
Copy link
Member

@benwtrent benwtrent commented Nov 7, 2025

Some testing...

@benwtrent
Copy link
Member Author

benwtrent commented Nov 7, 2025

@mayya-sharipova @ChrisHegarty ping

@benwtrent
Copy link
Member Author

benwtrent commented Nov 7, 2025

Buildkite benchmark this with so-vector please

ChrisHegarty
ChrisHegarty reviewed Nov 7, 2025
View reviewed changes
server/src/main/java/org/elasticsearch/index/MergeSchedulerConfig.java
"index.merge.scheduler.auto_throttle",
true,
// default to false in snapshot for testing
isSnapshot == false,
Copy link
Contributor

@ChrisHegarty ChrisHegarty Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning merge throttling off for snapshot builds is a great start to help us determine the potential impact of this across different benchmarks. 👍

@benwtrent
Copy link
Member Author

benwtrent commented Nov 7, 2025

Buildkite benchmark this with dense_vector please

@benwtrent
Copy link
Member Author

benwtrent commented Nov 10, 2025

Buildkite benchmark this with dense_vector please

@gbanasiak
Copy link
Contributor

gbanasiak commented Nov 10, 2025

@benwtrent The dense vector benchmark is called dense_vector-1n-4g.

@gbanasiak
Copy link
Contributor

gbanasiak commented Nov 10, 2025

Buildkite benchmark this with dense_vector-1n-4g please

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 10, 2025 •
edited
Loading

💚 Build Succeeded

This build ran two dense_vector-1n-4g benchmarks to evaluate performance impact of this PR.

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

>non-issue :Search Relevance/Vectors Vector search v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benwtrent @gbanasiak @elasticmachine @ChrisHegarty @elasticsearchmachine