-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ML] Introduce InferenceString wrapper object #137711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d54a43b
Introduce InferenceString wrapper object
DonalEvans 1bdc58c
Consistently assert that input list only contains text inputs
DonalEvans 8ab54bf
Merge branch 'main' into inference-string
DonalEvans 72a5615
Merge branch 'main' into inference-string
DonalEvans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
server/src/main/java/org/elasticsearch/inference/InferenceString.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the "Elastic License | ||
| * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side | ||
| * Public License v 1"; you may not use this file except in compliance with, at | ||
| * your election, the "Elastic License 2.0", the "GNU Affero General Public | ||
| * License v3.0 only", or the "Server Side Public License, v 1". | ||
| */ | ||
|
|
||
| package org.elasticsearch.inference; | ||
|
|
||
| import java.util.EnumSet; | ||
| import java.util.List; | ||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * This class represents a String which may be raw text, or the String representation of some other data such as an image in base64 | ||
| */ | ||
| public record InferenceString(String value, DataType dataType) { | ||
| /** | ||
| * Describes the type of data represented by an {@link InferenceString} | ||
| */ | ||
| public enum DataType { | ||
| TEXT, | ||
| IMAGE_BASE64 | ||
| } | ||
|
|
||
| private static final EnumSet<DataType> IMAGE_TYPES = EnumSet.of(DataType.IMAGE_BASE64); | ||
|
|
||
| /** | ||
| * Constructs an {@link InferenceString} with the given value and {@link DataType} | ||
| * @param value the String value | ||
| * @param dataType the type of data that the String represents | ||
| */ | ||
| public InferenceString(String value, DataType dataType) { | ||
| this.value = Objects.requireNonNull(value); | ||
| this.dataType = Objects.requireNonNull(dataType); | ||
| } | ||
|
|
||
| public boolean isImage() { | ||
| return IMAGE_TYPES.contains(dataType); | ||
| } | ||
|
|
||
| public boolean isText() { | ||
| return DataType.TEXT.equals(dataType); | ||
| } | ||
|
|
||
| /** | ||
| * Converts a list of {@link InferenceString} to a list of {@link String}. | ||
| * This method should only be called in code paths that do not deal with multimodal inputs; where all inputs are guaranteed to be | ||
| * raw text, since it discards the {@link org.elasticsearch.inference.InferenceString.DataType} associated with each input. | ||
| * | ||
| * @param inferenceStrings The list of {@link InferenceString} to convert to a list of {@link String} | ||
| * @return a list of String inference inputs that do not contain any non-text inputs | ||
| */ | ||
| public static List<String> toStringList(List<InferenceString> inferenceStrings) { | ||
| return inferenceStrings.stream().map(i -> { | ||
| assert i.isText() : "Non-text input passed to InferenceString.toStringList"; | ||
| return i.value(); | ||
| }).toList(); | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we filter out DataType.IMAGE_BASE64 items?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should just filter out non-text inputs, because if any manage to make it into one of the two places we call this method, then there's a problem somewhere. Maybe an assert like in
EmbeddingsInput.getTextInputs()just for safety? The two classes where this method is called (inElasticsearchInternalServiceandSageMakerService) don't useEmbeddingsInput, which is why there's a slightly different flow for them.