Boosted non-exhaustive enum deserialization (#7737)

Author: YohDeadfall

src/Elastic.Clients.Elasticsearch/Core/IEnumStruct.cs

@@ -0,0 +1,11 @@
+// Licensed to Elasticsearch B.V under one or more agreements.
+// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
+// See the LICENSE file in the project root for more information.
+
+namespace Elastic.Clients.Elasticsearch.Core;
+
+internal interface IEnumStruct<TSelf> where TSelf : struct, IEnumStruct<TSelf>
+{
+	// TODO: Can be made static when targeting .NET 7 and higher
+	TSelf Create(string value);
+}

src/Elastic.Clients.Elasticsearch/Serialization/EnumStructConverter.cs

@@ -3,24 +3,18 @@
 // See the LICENSE file in the project root for more information.
 
 using System;
-using System.Reflection;
 using System.Text.Json;
 using System.Text.Json.Serialization;
+using Elastic.Clients.Elasticsearch.Core;
 
 namespace Elastic.Clients.Elasticsearch.Serialization;
 
-internal sealed class EnumStructConverter<T> : JsonConverter<T> where T : new()
+internal sealed class EnumStructConverter<T> : JsonConverter<T> where T : struct, IEnumStruct<T>
 {
-	public override T? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
+	public override T Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
 	{
 		var value = reader.GetString();
-
-		var instance = (T)Activator.CreateInstance(
-			typeof(T),
-			BindingFlags.Instance | BindingFlags.NonPublic,
-			args: new object[] { value }, // TODO: Perf - Review use of ArrayPool
-			binder: null,
-			culture: null)!;
+		var instance = default(T).Create(value);
 
 		return instance;
 	}
@@ -30,7 +24,7 @@ public override void Write(Utf8JsonWriter writer, T value, JsonSerializerOptions
 		var enumValue = value.ToString();
 
 		if (!string.IsNullOrEmpty(enumValue))
-			writer.WriteStringValue(value.ToString());
+			writer.WriteStringValue(enumValue);
 		else
 			writer.WriteNullValue();
 	}

src/Elastic.Clients.Elasticsearch/_Generated/Types/Enums/Enums.Aggregations.g.cs

@@ -22,6 +22,7 @@
 using System.Text.Json.Serialization;
 using System.Runtime.Serialization;
 using Elastic.Transport;
+using Elastic.Clients.Elasticsearch.Core;
 using Elastic.Clients.Elasticsearch.Serialization;
 
 namespace Elastic.Clients.Elasticsearch.Aggregations;

src/Elastic.Clients.Elasticsearch/_Generated/Types/Enums/Enums.Analysis.g.cs

@@ -22,6 +22,7 @@
 using System.Text.Json.Serialization;
 using System.Runtime.Serialization;
 using Elastic.Transport;
+using Elastic.Clients.Elasticsearch.Core;
 using Elastic.Clients.Elasticsearch.Serialization;
 
 namespace Elastic.Clients.Elasticsearch.Analysis;

src/Elastic.Clients.Elasticsearch/_Generated/Types/Enums/Enums.Cluster.g.cs

@@ -22,6 +22,7 @@
 using System.Text.Json.Serialization;
 using System.Runtime.Serialization;
 using Elastic.Transport;
+using Elastic.Clients.Elasticsearch.Core;
 using Elastic.Clients.Elasticsearch.Serialization;
 
 namespace Elastic.Clients.Elasticsearch.Cluster;

src/Elastic.Clients.Elasticsearch/_Generated/Types/Enums/Enums.Core.Search.g.cs

@@ -22,6 +22,7 @@
 using System.Text.Json.Serialization;
 using System.Runtime.Serialization;
 using Elastic.Transport;
+using Elastic.Clients.Elasticsearch.Core;
 using Elastic.Clients.Elasticsearch.Serialization;
 
 namespace Elastic.Clients.Elasticsearch.Core.Search;
@@ -225,10 +226,12 @@ public override void Write(Utf8JsonWriter writer, HighlighterTagsSchema value, J
 }
 
 [JsonConverter(typeof(EnumStructConverter<HighlighterType>))]
-public readonly partial struct HighlighterType
+public readonly partial struct HighlighterType : IEnumStruct<HighlighterType>
 {
 	public HighlighterType(string value) => Value = value;
 
+	HighlighterType IEnumStruct<HighlighterType>.Create(string value) => value;
+
 	public readonly string Value { get; }
 	public static HighlighterType Unified { get; } = new HighlighterType("unified");
 	public static HighlighterType Plain { get; } = new HighlighterType("plain");

src/Elastic.Clients.Elasticsearch/_Generated/Types/Enums/Enums.Enrich.g.cs

@@ -22,6 +22,7 @@
 using System.Text.Json.Serialization;
 using System.Runtime.Serialization;
 using Elastic.Transport;
+using Elastic.Clients.Elasticsearch.Core;
 using Elastic.Clients.Elasticsearch.Serialization;
 
 namespace Elastic.Clients.Elasticsearch.Enrich;

src/Elastic.Clients.Elasticsearch/_Generated/Types/Enums/Enums.Eql.g.cs

@@ -22,6 +22,7 @@
 using System.Text.Json.Serialization;
 using System.Runtime.Serialization;
 using Elastic.Transport;
+using Elastic.Clients.Elasticsearch.Core;
 using Elastic.Clients.Elasticsearch.Serialization;
 
 namespace Elastic.Clients.Elasticsearch.Eql;

src/Elastic.Clients.Elasticsearch/_Generated/Types/Enums/Enums.IndexManagement.g.cs

@@ -22,6 +22,7 @@
 using System.Text.Json.Serialization;
 using System.Runtime.Serialization;
 using Elastic.Transport;
+using Elastic.Clients.Elasticsearch.Core;
 using Elastic.Clients.Elasticsearch.Serialization;
 
 namespace Elastic.Clients.Elasticsearch.IndexManagement;
@@ -497,10 +498,12 @@ public override void Write(Utf8JsonWriter writer, ShardRoutingState value, JsonS
 }
 
 [JsonConverter(typeof(EnumStructConverter<StorageType>))]
-public readonly partial struct StorageType
+public readonly partial struct StorageType : IEnumStruct<StorageType>
 {
 	public StorageType(string value) => Value = value;
 
+	StorageType IEnumStruct<StorageType>.Create(string value) => value;
+
 	public readonly string Value { get; }
 
 	/// <summary>

src/Elastic.Clients.Elasticsearch/_Generated/Types/Enums/Enums.Ingest.g.cs

@@ -22,6 +22,7 @@
 using System.Text.Json.Serialization;
 using System.Runtime.Serialization;
 using Elastic.Transport;
+using Elastic.Clients.Elasticsearch.Core;
 using Elastic.Clients.Elasticsearch.Serialization;
 
 namespace Elastic.Clients.Elasticsearch.Ingest;