Complted buckets JSON converter (#7738)

Author: YohDeadfall

src/Elastic.Clients.Elasticsearch/Serialization/UnionConverter.cs

@@ -122,12 +122,6 @@ private class DerivedUnionConverterInner<TType, TItem1, TItem2> : JsonConverter<
 		public override void Write(Utf8JsonWriter writer, TType value,
 			JsonSerializerOptions options)
 		{
-			if (value is null)
-			{
-				writer.WriteNullValue();
-				return;
-			}
-
 			if (value.Item1 is not null)
 			{
 				JsonSerializer.Serialize(writer, value.Item1, value.Item1.GetType(), options);
@@ -214,15 +208,30 @@ private class BucketsConverter<TBucket> : JsonConverter<Buckets<TBucket>>
 	{
 		public override Buckets<TBucket>? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
 		{
-			// TODO - Read ahead to establish the type - For now, hardcoded for lists
+			return reader.TokenType switch
+			{
+				JsonTokenType.Null => null,
+				JsonTokenType.StartArray => new(JsonSerializer.Deserialize<IReadOnlyCollection<TBucket>>(ref reader, options)),
+				JsonTokenType.StartObject => new(JsonSerializer.Deserialize<IReadOnlyDictionary<string, TBucket>>(ref reader, options)),
+				_ => throw new JsonException("Invalid bucket type")
+			};
+		}
 
-			var bucketType = typeToConvert.GetGenericArguments()[0];
+		public override void Write(Utf8JsonWriter writer, Buckets<TBucket> value, JsonSerializerOptions options)
+		{
+			if (value.Item1 is { } item1)
+			{
+				JsonSerializer.Serialize(writer, item1, options);
+				return;
+			}
 
-			var item = JsonSerializer.Deserialize(ref reader, typeof(IReadOnlyCollection<TBucket>), options);
+			if (value.Item2 is { } item2)
+			{
+				JsonSerializer.Serialize(writer, item2, options);
+				return;
+			}
 
-			return (Buckets<TBucket>)Activator.CreateInstance(typeof(Buckets<>).MakeGenericType(bucketType), item);
+			writer.WriteNullValue();
 		}
-
-		public override void Write(Utf8JsonWriter writer, Buckets<TBucket> value, JsonSerializerOptions options) => throw new NotImplementedException();
 	}
 }