remove hardcoded \r\n from code generator strings (#4158)

Mpdreamz · russcam · commit 2f8aaf3cfc3e · 2019-10-22T13:46:56.000+10:00
diff --git a/src/Auxiliary/Elasticsearch.Net.VirtualizedCluster/Audit/Auditor.cs b/src/Auxiliary/Elasticsearch.Net.VirtualizedCluster/Audit/Auditor.cs
@@ -123,9 +123,9 @@ public async Task<Auditor> TraceElasticsearchExceptionOnResponse(ClientCall call
 
 			Action call = () => { Response = _cluster.ClientCall(callTrace?.RequestOverrides); };
 			call();
-			
+
 			if (Response.ApiCall.Success) throw new Exception("Expected call to not be valid");
-				
+
 			var exception = Response.ApiCall.OriginalException as ElasticsearchClientException;
 			if (exception == null) throw new Exception("OriginalException on response is not expected ElasticsearchClientException");
 			assert(exception);
@@ -175,9 +175,10 @@ public async Task<Auditor> TraceUnexpectedException(ClientCall callTrace, Action
 
 		private Auditor AssertAuditTrails(ClientCall callTrace, int nthCall)
 		{
+			var nl = Environment.NewLine;
 			if (AuditTrail.Count != AsyncAuditTrail.Count)
-				throw new Exception($"{nthCall} has a mismatch between sync and async. \r\nasync:{AuditTrail}\r\nsync:{AsyncAuditTrail}");
-			
+				throw new Exception($"{nthCall} has a mismatch between sync and async. {nl}async:{AuditTrail}{nl}sync:{AsyncAuditTrail}");
+
 			AssertTrailOnResponse(callTrace, AuditTrail, true, nthCall);
 			AssertTrailOnResponse(callTrace, AuditTrail, false, nthCall);
 
@@ -226,7 +227,7 @@ private static void AssertTrailOnResponse(ClientCall callTrace, List<Elasticsear
 			var actualAuditTrail = auditTrail.Aggregate(new StringBuilder(Environment.NewLine),
 				(sb, a) => sb.AppendLine($"-> {a}"),
 				sb => sb.ToString());
-			
+
 			var traceEvents =callTrace.Select(c => c.Event).ToList();
 			var auditEvents = auditTrail.Select(a => a.Event).ToList();
 			if (!traceEvents.SequenceEqual(auditEvents))
@@ -239,19 +240,19 @@ private static void AssertTrailOnResponse(ClientCall callTrace, List<Elasticsear
 				var nthAuditTrailItem = (i + 1).ToOrdinal();
 				var because = $"thats the {{0}} specified on the {nthAuditTrailItem} item in the {nthClientCall} client call's {typeOfTrail}";
 				var c = callTrace[i];
-				if (audit.Event != c.Event) 
+				if (audit.Event != c.Event)
 					throw new Exception(string.Format(because, "event"));
-				if (c.Port.HasValue && audit.Node.Uri.Port != c.Port.Value) 
+				if (c.Port.HasValue && audit.Node.Uri.Port != c.Port.Value)
 					throw new Exception(string.Format(because, "port"));
-				
+
 				c.SimpleAssert?.Invoke(audit);
 				c.AssertWithBecause?.Invoke(string.Format(because, "custom assertion"), audit);
 			}
 
-			if (callTrace.Count != auditTrail.Count) 
+			if (callTrace.Count != auditTrail.Count)
 				throw new Exception($"callTrace has {callTrace.Count} items. Actual auditTrail {actualAuditTrail}");
 		}
-		
+
 		private static TException TryCall<TException>(Action call, Action<TException> assert) where TException : ElasticsearchClientException
 		{
 			TException exception = null;
diff --git a/src/CodeGeneration/ApiGenerator/Domain/Code/HighLevel/Requests/Constructor.cs b/src/CodeGeneration/ApiGenerator/Domain/Code/HighLevel/Requests/Constructor.cs
@@ -1,4 +1,5 @@
-﻿using System.Collections.Generic;
+﻿using System;
+using System.Collections.Generic;
 using System.Linq;
 using ApiGenerator.Configuration;
 using ApiGenerator.Domain.Specification;
@@ -7,7 +8,7 @@ namespace ApiGenerator.Domain.Code.HighLevel.Requests
 {
 	public class Constructor
 	{
-		private const string Indent = "\r\n\t\t";
+		private static readonly string Indent = $"{Environment.NewLine}\t\t";
 		public string AdditionalCode { get; set; } = string.Empty;
 		public bool Parameterless { get; set; }
 		public string Body { get; set; }
@@ -28,15 +29,15 @@ public static IEnumerable<Constructor> RequestConstructors(CsharpNames names, Ur
 			var generateGeneric = CodeConfiguration.GenericOnlyInterfaces.Contains(names.RequestInterfaceName) || !inheritsFromPlainRequestBase;
 			return GenerateConstructors(url, inheritsFromPlainRequestBase, generateGeneric, names.RequestName, generic);
 		}
-		
-		private static string FirstGeneric(string fullGenericString) => 
+
+		private static string FirstGeneric(string fullGenericString) =>
 			fullGenericString?.Replace("<", "").Replace(">", "").Split(",").First().Trim();
 
 		private static IEnumerable<Constructor> GenerateConstructors(
 			UrlInformation url,
 			bool inheritsFromPlainRequestBase,
 			bool generateGeneric,
-			string typeName, 
+			string typeName,
 			string generic
 		)
 		{
@@ -64,8 +65,8 @@ string generic
 				ctors.AddRange(from path in paths.Where(path => path.HasResolvableArguments)
 					let baseArgs = path.AutoResolveBaseArguments(generic)
 					let constructorArgs = path.AutoResolveConstructorArguments
-					let baseOrThis = inheritsFromPlainRequestBase  
-						? "this" 
+					let baseOrThis = inheritsFromPlainRequestBase
+						? "this"
 						: "base"
 					let generated = $"public {typeName}({constructorArgs}) : {baseOrThis}({baseArgs})"
 					select new Constructor
@@ -84,7 +85,7 @@ string generic
 					{
 						Parameterless = string.IsNullOrEmpty(docPathConstArgs),
 						Generated = $"public {typeName}({docPathConstArgs}) : this({docPathBaseArgs})",
-		
+
 						AdditionalCode = $"partial void DocumentFromPath({generic} document);",
 						Description = docPath.GetXmlDocs(Indent, skipResolvable: true, documentConstructor: true),
 						Body = "=> DocumentFromPath(documentWithId);"
diff --git a/src/CodeGeneration/ApiGenerator/Generator/CodeGenerator.cs b/src/CodeGeneration/ApiGenerator/Generator/CodeGenerator.cs
@@ -19,7 +19,7 @@ public static string Property(string type, string name, string key, string sette
 			if (!string.IsNullOrWhiteSpace(obsolete)) A($"[Obsolete(\"Scheduled to be removed in 7.0, {obsolete}\")]");
 
 			A(PropertyGenerator(type, name, key, setter));
-			return string.Join("\r\n\t\t", components);
+			return string.Join($"{Environment.NewLine}\t\t", components);
 
 			void A(string s)
 			{
@@ -36,7 +36,7 @@ public static string Constructor(Constructor c)
 			A(generated);
 			if (!c.Body.IsNullOrEmpty()) A(c.Body);
 			if (!c.AdditionalCode.IsNullOrEmpty()) A(c.AdditionalCode);
-			return string.Join("\r\n\t\t", components);
+			return string.Join($"{Environment.NewLine}\t\t", components);
 
 			void A(string s)
 			{
diff --git a/src/CodeGeneration/ApiGenerator/Views/HighLevel/Descriptors/XmlDocs.cshtml b/src/CodeGeneration/ApiGenerator/Views/HighLevel/Descriptors/XmlDocs.cshtml
@@ -6,7 +6,7 @@
 @inherits ApiGenerator.CodeTemplatePage<List<string>>
 @{
 	List<string> summary = Model;
-	var description = summary.Count == 1 ? summary.First() : string.Join("\r\n\t\t", summary.Select(d => "/// " + d));
+	var description = summary.Count == 1 ? summary.First() : string.Join($"{Environment.NewLine}\t\t", summary.Select(d => "/// " + d));
 	if (summary.Count == 1)
 	{
 <text>		///<summary>@Raw(description)</summary></text>
diff --git a/src/CodeGeneration/ApiGenerator/Views/LowLevel/Enums.Generated.cshtml b/src/CodeGeneration/ApiGenerator/Views/LowLevel/Enums.Generated.cshtml
@@ -18,7 +18,7 @@
 		var enumCsharp = string.Format("[EnumMember(Value = \"{0}\")] {1}{2}", value, enumValue, i.HasValue ? " = 1 << " + i.Value : null);
 		if (GlobalOverrides.ObsoleteEnumMembers.TryGetValue(enumName, out var d) && d.TryGetValue(value, out var obsolete))
 		{
-			return string.Format("[Obsolete(\"{0}\")]\r\n\t\t{1}", obsolete, enumCsharp);
+			return string.Format("[Obsolete(\"{0}\")]{2}\t\t{1}", obsolete, enumCsharp, Environment.NewLine);
 		}
 		return enumCsharp;
 	}
@@ -62,7 +62,7 @@ namespace Elasticsearch.Net
 	<text>
 	@(isFlag ? "[Flags, StringEnum]" : "[StringEnum]")public enum @e.Name
 	{
-		@Raw(string.Join(",\r\n\t\t", e.Options.OrderBy(s => s == "_all" ? 1 : 0).Select((s, i) => CreateEnum(e.Name, s, isFlag ? (int?)i : null))))
+		@Raw(string.Join(","+ Environment.NewLine + "\t\t", e.Options.OrderBy(s => s == "_all" ? 1 : 0).Select((s, i) => CreateEnum(e.Name, s, isFlag ? (int?)i : null))))
 	}</text>
 }
 
@@ -124,7 +124,7 @@ namespace Elasticsearch.Net
 		{
 			<text>	switch (enumValue)
 			{
-				@Raw(string.Join("\r\n\t\t\t\t", e.Options.Select(o => CreateCase(e.Name, o))))
+				@Raw(string.Join(Environment.NewLine + "\t\t\t\t", e.Options.Select(o => CreateCase(e.Name, o))))
 			}
 			throw new ArgumentException($"'{enumValue.ToString()}' is not a valid value for enum '@(e.Name)'");
 		}</text>
diff --git a/src/CodeGeneration/DocGenerator/AsciiDoc/GeneratedAsciidocVisitor.cs b/src/CodeGeneration/DocGenerator/AsciiDoc/GeneratedAsciidocVisitor.cs
@@ -75,11 +75,12 @@ public override void VisitDocument(Document document)
 			var originalFile = Regex.Replace(_source.FullName.Replace("\\", "/"), @"^(.*Tests/)",
 				$"{github}/tree/{Program.BranchName}/src/Tests/Tests/");
 
+			var eol = Environment.NewLine;
 			_newDocument.Insert(0, new Comment
 			{
 				Style = CommentStyle.MultiLine,
-				Text = $"IMPORTANT NOTE\r\n==============\r\nThis file has been generated from {originalFile}. \r\n" +
-					"If you wish to submit a PR for any spelling mistakes, typos or grammatical errors for this file,\r\n" +
+				Text = $"IMPORTANT NOTE{eol}=============={eol}This file has been generated from {originalFile}. {eol}" +
+					$"If you wish to submit a PR for any spelling mistakes, typos or grammatical errors for this file,{eol}" +
 					"please modify the original csharp file found at the link and submit the PR with that change. Thanks!"
 			});
 
diff --git a/src/CodeGeneration/DocGenerator/AsciiDoc/RawAsciidocVisitor.cs b/src/CodeGeneration/DocGenerator/AsciiDoc/RawAsciidocVisitor.cs
@@ -31,11 +31,12 @@ public override void VisitDocument(Document document)
 			var github = "https://github.com/elastic/elasticsearch-net";
 			var originalFile = Regex.Replace(_source.FullName.Replace("\\", "/"),
 				@"^(.*Tests/)", $"{github}/tree/{Program.BranchName}/src/Tests/Tests/");
+			var eol = Environment.NewLine;
 			document.Insert(0, new Comment
 			{
 				Style = CommentStyle.MultiLine,
-				Text = $"IMPORTANT NOTE\r\n==============\r\nThis file has been generated from {originalFile}. \r\n" +
-					"If you wish to submit a PR for any spelling mistakes, typos or grammatical errors for this file,\r\n" +
+				Text = $"IMPORTANT NOTE{eol}=============={eol}This file has been generated from {originalFile}. {eol}" +
+					$"If you wish to submit a PR for any spelling mistakes, typos or grammatical errors for this file,{eol}" +
 					"please modify the original csharp file found at the link and submit the PR with that change. Thanks!"
 			});
 
diff --git a/src/CodeGeneration/DocGenerator/XmlDocs/XmlDocsVisitor.cs b/src/CodeGeneration/DocGenerator/XmlDocs/XmlDocsVisitor.cs
@@ -17,7 +17,7 @@ public class XmlDocsVisitor : Visitor
 	{
 		// AsciiDocNet does not currently have a type for list item continuations, so mimic here
 		// for the moment
-		private const string ListItemContinuation = "\r\n+\r\n";
+		private static readonly string ListItemContinuation = Environment.NewLine + "+" + Environment.NewLine;
 		private readonly Type _type;
 		private LabeledListItem _labeledListItem;
 
diff --git a/src/Elasticsearch.Net/Responses/ResponseStatics.cs b/src/Elasticsearch.Net/Responses/ResponseStatics.cs
@@ -30,8 +30,8 @@ public static string DebugInformationBuilder(IApiCallDetails r, StringBuilder sb
 
 			var response = r.ResponseBodyInBytes?.Utf8String() ?? ResponseAlreadyCaptured;
 			var request = r.RequestBodyInBytes?.Utf8String() ?? RequestAlreadyCaptured;
-			sb.AppendLine($"# Request:\r\n{request}");
-			sb.AppendLine($"# Response:\r\n{response}");
+			sb.AppendLine($"# Request:{Environment.NewLine}{request}");
+			sb.AppendLine($"# Response:{Environment.NewLine}{response}");
 
 			return sb.ToString();
 		}
@@ -42,7 +42,7 @@ public static void DebugAuditTrailExceptions(List<Audit> auditTrail, StringBuild
 
 			var auditExceptions = auditTrail.Select((audit, i) => new { audit, i }).Where(a => a.audit.Exception != null);
 			foreach (var a in auditExceptions)
-				sb.AppendLine($"# Audit exception in step {a.i + 1} {a.audit.Event.GetStringValue()}:\r\n{a.audit.Exception}");
+				sb.AppendLine($"# Audit exception in step {a.i + 1} {a.audit.Event.GetStringValue()}:{Environment.NewLine}{a.audit.Exception}");
 		}
 
 		public static void DebugAuditTrail(List<Audit> auditTrail, StringBuilder sb)
diff --git a/src/Tests/Tests.Core/Extensions/DiffExtensions.cs b/src/Tests/Tests.Core/Extensions/DiffExtensions.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Linq;
 using System.Text;
 using System.Text.RegularExpressions;
@@ -81,8 +82,9 @@ private static string CreateDiff(string expected, string actual, string message,
 
 		private static string AppendCsharpApproximation(string expected, string actual, string diff)
 		{
-			diff += "\r\n C# approximation of actual ------ ";
-			diff += "\r\n new ";
+			var eol = Environment.NewLine;
+			diff += $"{eol} C# approximation of actual ------ ";
+			diff += $"{eol} new ";
 			var approx = Regex.Replace(actual, @"^(?=.*:.*)[^:]+:", (s) => s
 							.Value.Replace("\"", "")
 							.Replace(":", " =")
@@ -93,8 +95,8 @@ private static string AppendCsharpApproximation(string expected, string actual,
 			approx = Regex.Replace(approx, @"^\s*\],?.*$", s => s.Value.Replace("]", "}"), RegexOptions.Multiline);
 			diff += approx + ";";
 
-			diff += "\r\n C# approximation of expected ------ ";
-			diff += "\r\n new ";
+			diff += $"{eol} C# approximation of expected ------ ";
+			diff += $"{eol} new ";
 			approx = Regex.Replace(expected, @"^(?=.*:.*)[^:]+:", (s) => s
 							.Value.Replace("\"", "")
 							.Replace(":", " =")
diff --git a/src/Tests/Tests.Core/ManagedElasticsearch/Tasks/WriteAnalysisFiles.cs b/src/Tests/Tests.Core/ManagedElasticsearch/Tasks/WriteAnalysisFiles.cs
@@ -1,3 +1,4 @@
+using System;
 using System.IO;
 using Elastic.Managed.ConsoleWriters;
 using Elastic.Managed.Ephemeral;
@@ -38,8 +39,8 @@ private static void SetupHunspellFiles(string configPath)
 			if (File.Exists(hunspellPrefix + ".dic")) return;
 
 			Directory.CreateDirectory(hunspellFolder);
-			File.WriteAllText(hunspellPrefix + ".dic", "1\r\nabcdegf");
-			File.WriteAllText(hunspellPrefix + ".aff", "SET UTF8\r\nSFX P Y 1\r\nSFX P 0 s");
+			File.WriteAllText(hunspellPrefix + ".dic", $"1{Environment.NewLine}abcdegf");
+			File.WriteAllText(hunspellPrefix + ".aff", $"SET UTF8{Environment.NewLine}SFX P Y 1{Environment.NewLine}SFX P 0 s");
 		}
 
 		private static void SetupIcuFiles(string configPath)
diff --git a/src/Tests/Tests/Framework/Extensions/UriExtensions.cs b/src/Tests/Tests/Framework/Extensions/UriExtensions.cs
@@ -34,16 +34,16 @@ private static Uri CreateUri(Uri baseUri, Dictionary<string, string> newQueryStr
 
 		private static void AssertQueryString(Uri actualUri, Uri expectedUri, string origin)
 		{
-			var because = $"\r\nExpected query string from {origin}: {expectedUri.Query} on {expectedUri.PathAndQuery}";
-			because += $"\r\nActual querystring from {origin}  : {actualUri.Query} on {actualUri.PathAndQuery}\r\n";
+			var eol = Environment.NewLine;
+			var because = $"{eol} query string from {origin}: {expectedUri.Query} on {expectedUri.PathAndQuery}";
+			because += $"{eol}Actual querystring from {origin}  : {actualUri.Query} on {actualUri.PathAndQuery}{eol}";
 
 			var actualParameters = ExplodeQueryString(actualUri);
 			var expectedParameters = ExplodeQueryString(expectedUri);
 
 			actualParameters.Keys.Should()
-				.BeEquivalentTo(expectedParameters.Keys, "All query string parameters need to be asserted.\r\n{0}", because);
+				.BeEquivalentTo(expectedParameters.Keys, $"All query string parameters need to be asserted.{eol}{{0}}", because);
 
-			//actualParameters.Count.Should().Be(expectedParameters.Count, "All query string parameters need to be asserted.\r\n{0}", because);
 			if (actualParameters.Count == 0) return;
 
 			actualParameters.Should().ContainKeys(expectedParameters.Keys.ToArray(), because);
@@ -58,8 +58,9 @@ private static void AssertSpecialQueryStringValues(
 			string origin
 		)
 		{
-			var because = $"\r\nExpected query string from {origin}: {expectedUri.Query} on {expectedUri.PathAndQuery}";
-			because += $"\r\nActual query string from {origin}: {actualUri.Query} on {actualUri.PathAndQuery}\r\n";
+			var eol = Environment.NewLine;
+			var because = $"{eol}Expected query string from {origin}: {expectedUri.Query} on {expectedUri.PathAndQuery}";
+			because += $"{eol}Actual query string from {origin}: {actualUri.Query} on {actualUri.PathAndQuery}{eol}";
 
 			//only assert these if they appear in expectedUri
 			var specialQueryStringParameters = new[] { "pretty", "typed_keys", "error_trace" };
@@ -68,9 +69,9 @@ string origin
 				if (!expectedParameters.ContainsKey(key)) continue;
 
 				var expected = expectedParameters[key];
-				actualParameters.Should().ContainKey(key, "query value for '{0}' expected to exist\r\n{1}", key, because);
+				actualParameters.Should().ContainKey(key, $"query value for '{{0}}' expected to exist{eol}{{1}}", key, because);
 				var actual = actualParameters[key];
-				new[] { key, actual }.Should().BeEquivalentTo(new[] { key, expected }, "query value for '{0}' should be equal\r\n{1}", key, because);
+				new[] { key, actual }.Should().BeEquivalentTo(new[] { key, expected }, $"query value for '{{0}}' should be equal{eol}{{1}}", key, because);
 			}
 
 			foreach (var key in specialQueryStringParameters)
@@ -82,8 +83,9 @@ string origin
 
 		private static void ComparePaths(Uri actualUri, Uri expectedUri, string origin)
 		{
-			var because = $"\r\nExpected from {origin}: {expectedUri.PathAndQuery}";
-			because += $"\r\nActual from {origin}: {actualUri.PathAndQuery}\r\n";
+			var eol = Environment.NewLine;
+			var because = $"{eol}Expected from {origin}: {expectedUri.PathAndQuery}";
+			because += $"{eol}Actual from {origin}: {actualUri.PathAndQuery}{eol}";
 			actualUri.AbsolutePath.Should().Be(expectedUri.AbsolutePath, because);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public static string Property(string type, string name, string key, string sette`
`19`	`19`	`if (!string.IsNullOrWhiteSpace(obsolete)) A($"[Obsolete(\"Scheduled to be removed in 7.0, {obsolete}\")]");`
`20`	`20`
`21`	`21`	`A(PropertyGenerator(type, name, key, setter));`
`22`		`- return string.Join("\r\n\t\t", components);`
	`22`	`+ return string.Join($"{Environment.NewLine}\t\t", components);`
`23`	`23`
`24`	`24`	`void A(string s)`
`25`	`25`	`{`
`@@ -36,7 +36,7 @@ public static string Constructor(Constructor c)`
`36`	`36`	`A(generated);`
`37`	`37`	`if (!c.Body.IsNullOrEmpty()) A(c.Body);`
`38`	`38`	`if (!c.AdditionalCode.IsNullOrEmpty()) A(c.AdditionalCode);`
`39`		`- return string.Join("\r\n\t\t", components);`
	`39`	`+ return string.Join($"{Environment.NewLine}\t\t", components);`
`40`	`40`
`41`	`41`	`void A(string s)`
`42`	`42`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`@inherits ApiGenerator.CodeTemplatePage<List<string>>`
`7`	`7`	`@{`
`8`	`8`	`List<string> summary = Model;`
`9`		`- var description = summary.Count == 1 ? summary.First() : string.Join("\r\n\t\t", summary.Select(d => "/// " + d));`
	`9`	`+ var description = summary.Count == 1 ? summary.First() : string.Join($"{Environment.NewLine}\t\t", summary.Select(d => "/// " + d));`
`10`	`10`	`if (summary.Count == 1)`
`11`	`11`	`{`
`12`	`12`	`<text> ///<summary>@Raw(description)</summary></text>`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`var enumCsharp = string.Format("[EnumMember(Value = \"{0}\")] {1}{2}", value, enumValue, i.HasValue ? " = 1 << " + i.Value : null);`
`19`	`19`	`if (GlobalOverrides.ObsoleteEnumMembers.TryGetValue(enumName, out var d) && d.TryGetValue(value, out var obsolete))`
`20`	`20`	`{`
`21`		`- return string.Format("[Obsolete(\"{0}\")]\r\n\t\t{1}", obsolete, enumCsharp);`
	`21`	`+ return string.Format("[Obsolete(\"{0}\")]{2}\t\t{1}", obsolete, enumCsharp, Environment.NewLine);`
`22`	`22`	`}`
`23`	`23`	`return enumCsharp;`
`24`	`24`	`}`
`@@ -62,7 +62,7 @@ namespace Elasticsearch.Net`
`62`	`62`	`<text>`
`63`	`63`	`@(isFlag ? "[Flags, StringEnum]" : "[StringEnum]")public enum @e.Name`
`64`	`64`	`{`
`65`		`- @Raw(string.Join(",\r\n\t\t", e.Options.OrderBy(s => s == "_all" ? 1 : 0).Select((s, i) => CreateEnum(e.Name, s, isFlag ? (int?)i : null))))`
	`65`	`+ @Raw(string.Join(","+ Environment.NewLine + "\t\t", e.Options.OrderBy(s => s == "_all" ? 1 : 0).Select((s, i) => CreateEnum(e.Name, s, isFlag ? (int?)i : null))))`
`66`	`66`	`}</text>`
`67`	`67`	`}`
`68`	`68`
`@@ -124,7 +124,7 @@ namespace Elasticsearch.Net`
`124`	`124`	`{`
`125`	`125`	`<text> switch (enumValue)`
`126`	`126`	`{`
`127`		`- @Raw(string.Join("\r\n\t\t\t\t", e.Options.Select(o => CreateCase(e.Name, o))))`
	`127`	`+ @Raw(string.Join(Environment.NewLine + "\t\t\t\t", e.Options.Select(o => CreateCase(e.Name, o))))`
`128`	`128`	`}`
`129`	`129`	`throw new ArgumentException($"'{enumValue.ToString()}' is not a valid value for enum '@(e.Name)'");`
`130`	`130`	`}</text>`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ public class XmlDocsVisitor : Visitor`
`17`	`17`	`{`
`18`	`18`	`// AsciiDocNet does not currently have a type for list item continuations, so mimic here`
`19`	`19`	`// for the moment`
`20`		`- private const string ListItemContinuation = "\r\n+\r\n";`
	`20`	`+ private static readonly string ListItemContinuation = Environment.NewLine + "+" + Environment.NewLine;`
`21`	`21`	`private readonly Type _type;`
`22`	`22`	`private LabeledListItem _labeledListItem;`
`23`	`23`