Fix aggs integration tests where buckets can be empty (#4169)

russcam · web-flow · commit b63a4f3c12b9 · 2019-10-22T13:44:51.000+10:00
This commit fixes integration tests for aggregations that use a date_histogram aggregation,
where a bucker may have no documents with a specific seed value. For example,

build.bat seed:41075 integrate 7.4.0 "readonly"
diff --git a/src/Tests/Tests/Aggregations/Pipeline/BucketScript/BucketScriptAggregationUsageTests.cs b/src/Tests/Tests/Aggregations/Pipeline/BucketScript/BucketScriptAggregationUsageTests.cs
@@ -20,6 +20,7 @@ public BucketScriptAggregationUsageTests(ReadOnlyCluster cluster, EndpointUsage
 				{
 					field = "startedOn",
 					interval = "month",
+					min_doc_count = 1
 				},
 				aggs = new
 				{
@@ -77,6 +78,7 @@ public BucketScriptAggregationUsageTests(ReadOnlyCluster cluster, EndpointUsage
 			.DateHistogram("projects_started_per_month", dh => dh
 				.Field(p => p.StartedOn)
 				.Interval(DateInterval.Month)
+				.MinimumDocumentCount(1)
 				.Aggregations(aa => aa
 					.Sum("commits", sm => sm
 						.Field(p => p.NumberOfCommits)
@@ -106,6 +108,7 @@ public BucketScriptAggregationUsageTests(ReadOnlyCluster cluster, EndpointUsage
 			{
 				Field = "startedOn",
 				Interval = DateInterval.Month,
+				MinimumDocumentCount = 1,
 				Aggregations =
 					new SumAggregation("commits", "numberOfCommits") &&
 					new FilterAggregation("stable_state")
diff --git a/src/Tests/Tests/Aggregations/Pipeline/Derivative/DerivativeAggregationUsageTests.cs b/src/Tests/Tests/Aggregations/Pipeline/Derivative/DerivativeAggregationUsageTests.cs
@@ -21,6 +21,7 @@ public DerivativeAggregationUsageTests(ReadOnlyCluster cluster, EndpointUsage us
 				{
 					field = "startedOn",
 					interval = "month",
+					min_doc_count = 1
 				},
 				aggs = new
 				{
@@ -47,6 +48,7 @@ public DerivativeAggregationUsageTests(ReadOnlyCluster cluster, EndpointUsage us
 			.DateHistogram("projects_started_per_month", dh => dh
 				.Field(p => p.StartedOn)
 				.Interval(DateInterval.Month)
+				.MinimumDocumentCount(1)
 				.Aggregations(aa => aa
 					.Sum("commits", sm => sm
 						.Field(p => p.NumberOfCommits)
@@ -62,6 +64,7 @@ public DerivativeAggregationUsageTests(ReadOnlyCluster cluster, EndpointUsage us
 			{
 				Field = "startedOn",
 				Interval = DateInterval.Month,
+				MinimumDocumentCount = 1,
 				Aggregations =
 					new SumAggregation("commits", "numberOfCommits") &&
 					new DerivativeAggregation("commits_derivative", "commits")
diff --git a/src/Tests/Tests/Aggregations/Pipeline/MovingAverage/MovingAverageEwmaAggregationUsageTests.cs b/src/Tests/Tests/Aggregations/Pipeline/MovingAverage/MovingAverageEwmaAggregationUsageTests.cs
@@ -23,6 +23,7 @@ public MovingAverageEwmaAggregationUsageTests(ReadOnlyCluster cluster, EndpointU
 				{
 					field = "startedOn",
 					interval = "month",
+					min_doc_count = 1
 				},
 				aggs = new
 				{
@@ -54,6 +55,7 @@ public MovingAverageEwmaAggregationUsageTests(ReadOnlyCluster cluster, EndpointU
 			.DateHistogram("projects_started_per_month", dh => dh
 				.Field(p => p.StartedOn)
 				.Interval(DateInterval.Month)
+				.MinimumDocumentCount(1)
 				.Aggregations(aa => aa
 					.Sum("commits", sm => sm
 						.Field(p => p.NumberOfCommits)
@@ -74,6 +76,7 @@ public MovingAverageEwmaAggregationUsageTests(ReadOnlyCluster cluster, EndpointU
 			{
 				Field = "startedOn",
 				Interval = DateInterval.Month,
+				MinimumDocumentCount = 1,
 				Aggregations =
 					new SumAggregation("commits", "numberOfCommits")
 					&& new MovingAverageAggregation("commits_moving_avg", "commits")
diff --git a/src/Tests/Tests/Aggregations/Pipeline/MovingAverage/MovingAverageHoltLinearAggregationUsageTests.cs b/src/Tests/Tests/Aggregations/Pipeline/MovingAverage/MovingAverageHoltLinearAggregationUsageTests.cs
@@ -22,7 +22,8 @@ public MovingAverageHoltLinearAggregationUsageTests(ReadOnlyCluster cluster, End
 				date_histogram = new
 				{
 					field = "startedOn",
-					interval = "month"
+					interval = "month",
+					min_doc_count = 1
 				},
 				aggs = new
 				{
@@ -55,6 +56,7 @@ public MovingAverageHoltLinearAggregationUsageTests(ReadOnlyCluster cluster, End
 			.DateHistogram("projects_started_per_month", dh => dh
 				.Field(p => p.StartedOn)
 				.Interval(DateInterval.Month)
+				.MinimumDocumentCount(1)
 				.Aggregations(aa => aa
 					.Sum("commits", sm => sm.Field(p => p.NumberOfCommits))
 					.MovingAverage("commits_moving_avg", mv => mv
@@ -74,6 +76,7 @@ public MovingAverageHoltLinearAggregationUsageTests(ReadOnlyCluster cluster, End
 			{
 				Field = "startedOn",
 				Interval = DateInterval.Month,
+				MinimumDocumentCount = 1,
 				Aggregations =
 					new SumAggregation("commits", "numberOfCommits")
 					&& new MovingAverageAggregation("commits_moving_avg", "commits")
diff --git a/src/Tests/Tests/Aggregations/Pipeline/MovingAverage/MovingAverageHoltWintersAggregationUsageTests.cs b/src/Tests/Tests/Aggregations/Pipeline/MovingAverage/MovingAverageHoltWintersAggregationUsageTests.cs
@@ -21,7 +21,8 @@ public MovingAverageHoltWintersUsageTests(ReadOnlyCluster cluster, EndpointUsage
 				date_histogram = new
 				{
 					field = "startedOn",
-					interval = "month"
+					interval = "month",
+					min_doc_count = 1
 				},
 				aggs = new
 				{
@@ -59,6 +60,7 @@ public MovingAverageHoltWintersUsageTests(ReadOnlyCluster cluster, EndpointUsage
 			.DateHistogram("projects_started_per_month", dh => dh
 				.Field(p => p.StartedOn)
 				.Interval(DateInterval.Month)
+				.MinimumDocumentCount(1)
 				.Aggregations(aa => aa
 					.Sum("commits", sm => sm
 						.Field(p => p.NumberOfCommits)
@@ -85,6 +87,7 @@ public MovingAverageHoltWintersUsageTests(ReadOnlyCluster cluster, EndpointUsage
 			{
 				Field = "startedOn",
 				Interval = DateInterval.Month,
+				MinimumDocumentCount = 1,
 				Aggregations =
 					new SumAggregation("commits", "numberOfCommits")
 					&& new MovingAverageAggregation("commits_moving_avg", "commits")
@@ -124,7 +127,7 @@ protected override void ExpectResponse(ISearchResponse<Project> response)
 				var movingAverage = item.MovingAverage("commits_moving_avg");
 
 				// Moving Average specifies a window of 4 so
-				// moving average values should exist from 5th bucketr onwards
+				// moving average values should exist from 5th bucket onwards
 				if (bucketCount <= 4)
 					movingAverage.Should().BeNull();
 				else
diff --git a/src/Tests/Tests/Aggregations/Pipeline/MovingAverage/MovingAverageSimpleAggregationUsageTests.cs b/src/Tests/Tests/Aggregations/Pipeline/MovingAverage/MovingAverageSimpleAggregationUsageTests.cs
@@ -22,7 +22,7 @@ public MovingAverageSimpleAggregationUsageTests(ReadOnlyCluster cluster, Endpoin
 				date_histogram = new
 				{
 					field = "startedOn",
-					interval = "month",
+					interval = "month"
 				},
 				aggs = new
 				{
@@ -41,6 +41,7 @@ public MovingAverageSimpleAggregationUsageTests(ReadOnlyCluster cluster, Endpoin
 							model = "simple",
 							window = 30,
 							predict = 10,
+							gap_policy = "insert_zeros",
 							settings = new { }
 						}
 					}
@@ -61,6 +62,7 @@ public MovingAverageSimpleAggregationUsageTests(ReadOnlyCluster cluster, Endpoin
 						.BucketsPath("commits")
 						.Window(30)
 						.Predict(10)
+						.GapPolicy(GapPolicy.InsertZeros)
 						.Model(m => m
 							.Simple()
 						)
@@ -79,6 +81,7 @@ public MovingAverageSimpleAggregationUsageTests(ReadOnlyCluster cluster, Endpoin
 					{
 						Window = 30,
 						Predict = 10,
+						GapPolicy = GapPolicy.InsertZeros,
 						Model = new SimpleModel()
 					}
 			};
diff --git a/src/Tests/Tests/Aggregations/Pipeline/SerialDifferencing/SerialDifferencingAggregationUsageTests.cs b/src/Tests/Tests/Aggregations/Pipeline/SerialDifferencing/SerialDifferencingAggregationUsageTests.cs
@@ -19,7 +19,8 @@ public SerialDifferencingAggregationUsageTests(ReadOnlyCluster cluster, Endpoint
 				date_histogram = new
 				{
 					field = "startedOn",
-					interval = "month"
+					interval = "month",
+					min_doc_count = 1
 				},
 				aggs = new
 				{
@@ -47,6 +48,7 @@ public SerialDifferencingAggregationUsageTests(ReadOnlyCluster cluster, Endpoint
 			.DateHistogram("projects_started_per_month", dh => dh
 				.Field(p => p.StartedOn)
 				.Interval(DateInterval.Month)
+				.MinimumDocumentCount(1)
 				.Aggregations(aa => aa
 					.Sum("commits", sm => sm
 						.Field(p => p.NumberOfCommits)
@@ -63,6 +65,7 @@ public SerialDifferencingAggregationUsageTests(ReadOnlyCluster cluster, Endpoint
 			{
 				Field = "startedOn",
 				Interval = DateInterval.Month,
+				MinimumDocumentCount = 1,
 				Aggregations =
 					new SumAggregation("commits", "numberOfCommits")
 					&& new SerialDifferencingAggregation("second_difference", "commits")

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public MovingAverageSimpleAggregationUsageTests(ReadOnlyCluster cluster, Endpoin`
`22`	`22`	`date_histogram = new`
`23`	`23`	`{`
`24`	`24`	`field = "startedOn",`
`25`		`- interval = "month",`
	`25`	`+ interval = "month"`
`26`	`26`	`},`
`27`	`27`	`aggs = new`
`28`	`28`	`{`
`@@ -41,6 +41,7 @@ public MovingAverageSimpleAggregationUsageTests(ReadOnlyCluster cluster, Endpoin`
`41`	`41`	`model = "simple",`
`42`	`42`	`window = 30,`
`43`	`43`	`predict = 10,`
	`44`	`+ gap_policy = "insert_zeros",`
`44`	`45`	`settings = new { }`
`45`	`46`	`}`
`46`	`47`	`}`
`@@ -61,6 +62,7 @@ public MovingAverageSimpleAggregationUsageTests(ReadOnlyCluster cluster, Endpoin`
`61`	`62`	`.BucketsPath("commits")`
`62`	`63`	`.Window(30)`
`63`	`64`	`.Predict(10)`
	`65`	`+ .GapPolicy(GapPolicy.InsertZeros)`
`64`	`66`	`.Model(m => m`
`65`	`67`	`.Simple()`
`66`	`68`	`)`
`@@ -79,6 +81,7 @@ public MovingAverageSimpleAggregationUsageTests(ReadOnlyCluster cluster, Endpoin`
`79`	`81`	`{`
`80`	`82`	`Window = 30,`
`81`	`83`	`Predict = 10,`
	`84`	`+ GapPolicy = GapPolicy.InsertZeros,`
`82`	`85`	`Model = new SimpleModel()`
`83`	`86`	`}`
`84`	`87`	`};`