Skip to content

GH-5561 ensure that FILTER NOT EXIST is not lost when adding to an empty GroupGraphPattern #5562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-5561 ensure that FILTER NOT EXIST is not lost when adding to an empty GroupGraphPattern #5562

wants to merge 1 commit into from

Conversation

@seakayone
Copy link

@seakayone seakayone commented Nov 12, 2025 •
edited
Loading

GitHub issue resolved: #5561

Briefly describe the changes proposed in this PR:

Fix bug by ensuring specialized subclasses are only added not extracted when adding to a GroupGraphPattern.

Add example test for wrongly rendered FILTER NOT EXISTS query use cases.

PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@seakayone
eclipse-rdf4jGH-5561: (fix) Ensure that FILTER NOT EXIST is not lost …
7fdf806 
…when adding to an empty GroupGraphPattern

Fix bug by ensuring specialized subclasses are only added not extracted when adding to a GroupGraphPattern

Add example test for wrongly rendered FILTER NOT EXISTS query
@seakayone seakayone mentioned this pull request Nov 12, 2025
Open
@seakayone seakayone changed the title fix: Ensure that FILTER NOT EXIST is not lost when adding t… fix: Ensure that FILTER NOT EXIST is not lost when adding to an empty GroupGraphPattern Nov 12, 2025
@seakayone
Copy link
Author

seakayone commented Nov 12, 2025 •
edited
Loading

I will remove the comments in the test before merging this PR. I have left them for now in order to demonstrate the old/unfixed behaviour.

Some of the example tests may be redundant.
Should I move or remove some of them?

@seakayone seakayone changed the title fix: Ensure that FILTER NOT EXIST is not lost when adding to an empty GroupGraphPattern GH-5561 fix: Ensure that FILTER NOT EXIST is not lost when adding to an empty GroupGraphPattern Nov 12, 2025
@seakayone seakayone changed the title GH-5561 fix: Ensure that FILTER NOT EXIST is not lost when adding to an empty GroupGraphPattern GH-5561 ensure that FILTER NOT EXIST is not lost when adding to an empty GroupGraphPattern Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When adding a GraphPatterns.filterNotExists to an empty GraphPatterns.and() when rendering the FILTER NOT EXISTS is lost

1 participant

@seakayone