Remove commented out code that does not serve as documentation #3516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@elsazac WDYT? |
vogella
force-pushed
the
claude/identify-c-011CUrofTgRLK6VmDmBMtofb
branch
from
584ca25 to
1dc23a2
Compare
Member
Contributor
BeckerWdf
reviewed
Nov 10, 2025
| } | ||
|
|
||
| // /** | ||
| // * Note: This has been left commented out for further |
Member
There was a problem hiding this comment.
sounds like this commented code was kept by intention...
Contributor
Author
There was a problem hiding this comment.
I add to the commit message that this code was commented out 16 years ago (sufficient time for investigation). And the comment is still present in Git history.
| /** | ||
| * Markers have not changed | ||
| */ | ||
| private void handleNoMarkerChange() { |
Member
There was a problem hiding this comment.
may we now delete the empty method?
vogella
force-pushed
the
claude/identify-c-011CUrofTgRLK6VmDmBMtofb
branch
from
1dc23a2 to
ec919d6
Compare
This commit removes commented out code (dead code) from multiple files across the codebase. The commented code was no longer serving any documentation purpose and only added clutter. Changes include: Bundles: - MarkersChangeListener.java: Removed 150+ lines of commented method implementations (needsUpdate, affectsCurrentState, etc.) and related helper methods. This code was originally commented out on 2009-11-30 in commit b417bee (Bug 292525) with a note "left commented out for further investigation". After approximately 16 years, it is unlikely that further investigation will happen. Also removed the now-empty handleNoMarkerChange() method and its call site. - MarkerContentGenerator.java: Removed commented if statement - SelectionProcessor.java: Removed 27-line commented while loop block in multi-text selection paste handling - CSSDocumentHandlerImpl.java: Removed multiple commented code blocks in startMedia, endMedia, startFontFace, endFontFace methods - HeapStatus.java: Removed commented Kyrsoft view availability check Tests: - UIDialogs.java: Removed commented test implementations in testEditActionSetsDialog and testLoadNotExistingPerspective All removed code was identified as dead code that doesn't serve documentation purposes. Version control history preserves this code if needed for future reference. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
vogella
force-pushed
the
claude/identify-c-011CUrofTgRLK6VmDmBMtofb
branch
from
ec919d6 to
79e88af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes commented out code (dead code) from multiple files across the codebase. The commented code was no longer serving any documentation purpose and only added clutter.
Changes include:
Bundles:
Tests:
All removed code was identified as dead code that doesn't serve documentation purposes. Version control history preserves this code if needed for future reference.