-
Notifications
You must be signed in to change notification settings - Fork 227
Limit monitor-specific scaling to supported autoscale modes #3475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ShahzaibIbrahim
wants to merge
1
commit into
eclipse-platform:master
Choose a base branch
from
vi-eclipse:master-399
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
Author
|
Test failures are due to dependent PR: eclipse-platform/eclipse.platform.swt#2709 not being merged yet. |
28e96c8 to
d41719a
Compare
d41719a to
938b37b
Compare
1 task
938b37b to
07f8c15
Compare
HeikoKlare
reviewed
Nov 13, 2025
| WorkbenchMessages.RescaleAtRuntimeDisabledDescription); | ||
| note.setLayoutData(GridDataFactory.swtDefaults().span(2, 1).create()); | ||
| } else { | ||
| rescaleAtRuntime.setEnabled(true); |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can probably be removed as it should be enabled by default.
07f8c15 to
e03b834
Compare
These changes have following affects: - Upon starting eclipse product when monitor-specific scaling is set with unsupported autoscale mode, it will show a error dialog and application won't start. - User won't be able to enable monitor-specific scaling from appearance page if unsupported autoscale mode is set from property or ini file. - User can then either force the unsupported autoscale mode with monitor specific-scaling by setting swt.autoScale.force to true or switch to supported autoscale mode.
e03b834 to
3ca1192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes have following affects:
Testing
Scenario#1: Starting application with
-Dswt.autoScale=int200Result: App should start (if monitor-specific scaling is not checked in Appearance page), but option to turn on monitor-specific scaling in Appearance page should be disabled.
Scenario#2: Starting application with
-Dswt.autoScale=int200and-Dswt.autoScale.updateOnRuntime=trueResult: App will start, user will see an error dialog stating the incompatibility of an option and monitor specific-scaling will be disabled.
Scenario#3: Starting application with
-Dswt.autoScale=int200and-Dswt.autoScale.updateOnRuntime=trueand
-Dswt.autoScale.force=trueResult: makes more sense with swt applications. if user really wants to use other scaling mode with monitor-specific scaling.
Scenario#4: Starting application with
-Dswt.autoScale=quarterResult: App should start, and user should be able to turn on/off the monitor-specific scaling in Appearance page.
Note: following is the list of allowed autoscale values to be paired with monitor-specific scaling: ["false", "quarter", "exact"] or any concrete zoom value e.g. 225
Dependency