Skip to content

[GTK4] release OS resources for Shell during destroyWidget #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
+11 −10
Merged

[GTK4] release OS resources for Shell during destroyWidget #2745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4825,18 +4825,19 @@ void releaseWidget () {
@Override
void destroyWidget() {
if (GTK.GTK4) {
// Remove widget from hierarchy by removing it from parent container
if (parent != null) {
long currHandle = topHandle();

if (GTK.GTK_IS_WINDOW(currHandle)) {
GTK4.gtk_window_destroy(currHandle);
} else {
if (fixedHandle != 0) {
OS.swt_fixed_remove(parent.parentingHandle(), fixedHandle);
}
long currHandle = topHandle();
if (GTK.GTK_IS_WINDOW(currHandle)) {
// GTK windows don't have a parent, so destroy it now
GTK4.gtk_window_destroy(currHandle);
} else if (parent != null) {
if (fixedHandle != 0) {
// Remove widget from hierarchy by removing it from parent container
OS.swt_fixed_remove(parent.parentingHandle(), fixedHandle);
}
} else {
assert false : "widgets must have a parent or be a GtkWindow";
}

releaseHandle();
} else {
super.destroyWidget();
Expand Down
Loading