Skip to content

Do not call addListener in constructors of CCombo and StyledText #2733 #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not call addListener in constructors of CCombo and StyledText #2733 #2739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion bundles/org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CCombo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,18 @@ public CCombo (Composite parent, int style) {
}

initAccessible();
addListener(SWT.ZoomChanged, this::handleDPIChange);

// Add listener asynchronously in order to delay execution. This works because
// other DPI changes are also executed asynchronously but if we choose to revert
// back to synchronous execution of the listeners then this async call may be
// executed too late and zoom change events may happen too early and not get
// propagated.
// See https://github.com/eclipse-platform/eclipse.platform.swt/issues/2733
getDisplay().asyncExec(() -> {
if (!isDisposed()) {
addListener(SWT.ZoomChanged, this::handleDPIChange);
}
});
}
static int checkStyle (int style) {
int mask = SWT.BORDER | SWT.READ_ONLY | SWT.FLAT | SWT.LEFT_TO_RIGHT | SWT.RIGHT_TO_LEFT | SWT.LEAD | SWT.CENTER | SWT.TRAIL;
Expand Down
13 changes: 12 additions & 1 deletion .../org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/StyledText.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,18 @@ public StyledText(Composite parent, int style) {
initializeAccessible();
setData("DEFAULT_DROP_TARGET_EFFECT", new StyledTextDropTargetEffect(this));
if (IS_MAC) setData(STYLEDTEXT_KEY);
addListener(SWT.ZoomChanged, this::handleDPIChange);

// Add listener asynchronously in order to delay execution. This works because
// other DPI changes are also executed asynchronously but if we choose to revert
// back to synchronous execution of the listeners then this async call may be
// executed too late and zoom change events may happen too early and not get
// propagated.
// See https://github.com/eclipse-platform/eclipse.platform.swt/issues/2733
getDisplay().asyncExec(() -> {
if (!isDisposed()) {
addListener(SWT.ZoomChanged, this::handleDPIChange);
}
});
}
/**
* Adds an extended modify listener. An ExtendedModify event is sent by the
Expand Down
Loading