Migrate settings to pydantic v2 #156
Open
+23
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@eadwinCode I fixed the pipeline to include pydantic-settings during build. Can you please run the pipeline again? (sidenote: seems like the pipeline has a hardcoded list of packages that get installed, would it maybe make more sense to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eadwinCode
Here my attempt at upgrading the settings to pydantic v2, using pydantic-settings. Using
__getattribute__is a bit hacky imo, but seems to do the trick. Installing the package in Python 3.14 now also works. Let me know what you think 😃PR relates to this issue: #154