Skip to content

Add scale option for page break pad height #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add scale option for page break pad height #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13,921 changes: 6,961 additions & 6,960 deletions dist/html2pdf.bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/html2pdf.bundle.min.js
View file
Open in desktop

Large diffs are not rendered by default.

1,237 changes: 1,217 additions & 20 deletions dist/html2pdf.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/html2pdf.min.js
View file
Open in desktop

Large diffs are not rendered by default.

1,230 changes: 1,213 additions & 17 deletions dist/include/html2pdf.es.js
View file
Open in desktop

Large diffs are not rendered by default.

1,230 changes: 1,213 additions & 17 deletions dist/require/html2pdf.cjs.js
View file
Open in desktop

Large diffs are not rendered by default.

41 changes: 30 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions src/plugin/pagebreaks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ Worker.prototype.toContainer = function toContainer() {
// Get element position on the screen.
// TODO: Subtract the top of the container from clientRect.top/bottom?
var clientRect = el.getBoundingClientRect();
var scale = self.opt.scale

// Avoid: Check if a break happens mid-element.
if (rules.avoid && !rules.before) {
Expand All @@ -116,7 +117,7 @@ Worker.prototype.toContainer = function toContainer() {
if (rules.before) {
var pad = createElement('div', {style: {
display: 'block',
height: pxPageHeight - (clientRect.top % pxPageHeight) + 'px'
height: (pxPageHeight - (clientRect.top % pxPageHeight)) * scale + 'px'
}});
el.parentNode.insertBefore(pad, el);
}
Expand All @@ -125,7 +126,7 @@ Worker.prototype.toContainer = function toContainer() {
if (rules.after) {
var pad = createElement('div', {style: {
display: 'block',
height: pxPageHeight - (clientRect.bottom % pxPageHeight) + 'px'
height: (pxPageHeight - (clientRect.bottom % pxPageHeight)) * scale + 'px'
}});
el.parentNode.insertBefore(pad, el.nextSibling);
}
Expand Down
3 changes: 2 additions & 1 deletion src/worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ Worker.template = {
image: { type: 'jpeg', quality: 0.95 },
enableLinks: true,
html2canvas: {},
jsPDF: {}
jsPDF: {},
scale: 1
}
};

Expand Down