fix: regression when an alias is directly imported from a sibling or a parent

Author: chapa

src/rules/prefer-alias.js

@@ -118,8 +118,12 @@ export default {
           })
         }
 
+        const isDirectAlias =
+          options.alias |> keys |> some(alias => sourcePath === alias)
+
         const shouldUnalias =
           hasAlias &&
+          !isDirectAlias &&
           (((importWithoutAlias |> isSiblingImport) && !options.forSiblings) ||
             ((importWithoutAlias |> isSubpathImport) && !options.forSubpaths))
         if (shouldUnalias) {

src/rules/prefer-alias.spec.js

@@ -245,6 +245,32 @@ export default tester(
         output: "import foo from '@/foo'",
       })
     },
+    'direct import of an alias from a parent': async () => {
+      await outputFiles({
+        '.babelrc.json': JSON.stringify({
+          plugins: [
+            [
+              packageName`babel-plugin-module-resolver`,
+              { alias: { '@components': './sub/components' } },
+            ],
+          ],
+        }),
+      })
+      expect(lint("import { foo } from '@components'").messages).toEqual([])
+    },
+    'direct import of an alias from a sibling': async () => {
+      await outputFiles({
+        '.babelrc.json': JSON.stringify({
+          plugins: [
+            [
+              packageName`babel-plugin-module-resolver`,
+              { alias: { '@components': './components' } },
+            ],
+          ],
+        }),
+      })
+      expect(lint("import { foo } from '@components'").messages).toEqual([])
+    },
     'direct import of an alias from another one': async () => {
       await outputFiles({
         '.babelrc.json': JSON.stringify({