fix: handle when an alias is directly imported from another one

Author: chapa

src/rules/prefer-alias.js

@@ -75,7 +75,10 @@ export default {
         const hasAlias =
           options.alias
           |> keys
-          |> some(alias => sourcePath |> startsWith(`${alias}/`))
+          |> some(
+            alias =>
+              (sourcePath |> startsWith(`${alias}/`)) || sourcePath === alias,
+          )
 
         const importWithoutAlias = resolvePath(sourcePath, currentFile, options)
 
@@ -96,10 +99,11 @@ export default {
 
           const absoluteImportPath = P.resolve(folder, sourcePath)
 
-          const rewrittenImport = `${matchingAlias.name}/${
-            P.relative(matchingAlias.path, absoluteImportPath)
-            |> replace(/\\/g, '/')
-          }`
+          const rewrittenImport =
+            `${matchingAlias.name}/${
+              P.relative(matchingAlias.path, absoluteImportPath)
+              |> replace(/\\/g, '/')
+            }` |> replace(/\/$/, '')
 
           const importType = getImportType(importWithoutAlias)
 

src/rules/prefer-alias.spec.js

@@ -245,6 +245,26 @@ export default tester(
         output: "import foo from '@/foo'",
       })
     },
+    'direct import of an alias from another one': async () => {
+      await outputFiles({
+        '.babelrc.json': JSON.stringify({
+          plugins: [
+            [
+              packageName`babel-plugin-module-resolver`,
+              { alias: { '@components': './components', '@hooks': './hooks' } },
+            ],
+          ],
+        }),
+      })
+      expect(
+        lint("import { foo } from '../hooks'", {
+          filename: 'components/bar.js',
+        }),
+      ).toEqual({
+        messages: ["Unexpected parent import '../hooks'. Use '@hooks' instead"],
+        output: "import { foo } from '@hooks'",
+      })
+    },
     external: async () => {
       await fs.outputFile(
         '.babelrc.json',