PIR: Implement pixels for breakage KPIs #7108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
karlenDimla
force-pushed
the
feature/karl/pir/increase-observability-custom-stats-pixel
branch
from
af869e4 to
30df5b0
Compare
karlenDimla
force-pushed
the
feature/karl/pir/increase-observability-optout-7-14-21-42
branch
from
4ee35b5 to
93a6e27
Compare
karlenDimla
force-pushed
the
feature/karl/pir/increase-observability-optout-7-14-21-42
branch
from
93a6e27 to
b20e196
Compare
landomen
approved these changes
Nov 17, 2025
Contributor
landomen
left a comment
landomen
left a comment
There was a problem hiding this comment.
Works as expected, great job on adding all these pixels 🙌
...pl/src/main/java/com/duckduckgo/pir/impl/pixels/OptOut24HourSubmissionSuccessRateReporter.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+140
to
+141
| now: Long, | ||
| interval: Long, |
Contributor
There was a problem hiding this comment.
nit: we could use Kotlin's Duration class instead of Long for easier calculations, but might be hard to switch now considering we are using Long everywhere already
Contributor
Author
There was a problem hiding this comment.
I will consider updating this on the next changes. Feel free to use it on your changes if you think it’s better / cleaner. We can move things later as we go.
karlenDimla
merged commit dcbd7ba
into
feature/karl/pir/increase-observability-custom-stats-pixel
6 of 7 checks passed
karlenDimla
deleted the
feature/karl/pir/increase-observability-optout-7-14-21-42
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211848227486283?focus=true
Description
See attached task description
Steps to test this PR
https://app.asana.com/1/137249556945/project/72649045549333/task/1211863510648442?focus=true