Skip to content

Remove main RC checks in BrowserTabFragment/VM #7095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Remove main RC checks in BrowserTabFragment/VM #7095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
82b5e77
Make onActivityCreated non-blocking
CrisBarreiro Nov 10, 2025
2f34bba
Check siteErrorHandlerKillSwitch.self from io
CrisBarreiro Nov 10, 2025
af1e91f
Check serpSettingsSync from io
CrisBarreiro Nov 10, 2025
376d28c
Don't check featuresRequestHeader from main in renderOmnibarViewState
CrisBarreiro Nov 10, 2025
ccca9e9
Check serpEasterEggLogosToggles from io
CrisBarreiro Nov 10, 2025
e6c3e76
Fix tests
CrisBarreiro Nov 10, 2025
4d4b31d
Fix CI issue after resolving conflicts
CrisBarreiro Nov 12, 2025
15dfa7b
Address PR comments
CrisBarreiro Nov 12, 2025
5d3ec09
Fix onboarding bug
CrisBarreiro Nov 12, 2025
590b8cb
Update e2e test action
CrisBarreiro Nov 13, 2025
3fe08b8
Check swiping tabs from io
CrisBarreiro Nov 13, 2025
b7b3680
Reduce coroutine launches and move sharedPrefs access to io
CrisBarreiro Nov 13, 2025
64be6b0
Update workflows
CrisBarreiro Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions .github/workflows/ads-end-to-end.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
uses: actions/checkout@v4
with:
submodules: recursive
ref: 'feature/cris/on-activity-created-non-blocking'

- name: Set up JDK version
uses: actions/setup-java@v4
Expand Down Expand Up @@ -65,15 +66,4 @@ jobs:
app-file: apk/release.apk
android-api-level: 30
workspace: .maestro
include-tags: androidDesignSystemTest

- name: Create Asana task when workflow failed
if: ${{ failure() }}
uses: honeycombio/gha-create-asana-task@main
with:
asana-secret: ${{ secrets.ASANA_ACCESS_TOKEN }}
asana-workspace-id: ${{ secrets.GH_ASANA_WORKSPACE_ID }}
asana-project-id: ${{ secrets.GH_ASANA_AOR_PROJECT_ID }}
asana-section-id: ${{ secrets.GH_ASANA_INCOMING_ID }}
asana-task-name: GH Workflow Failure - ADS Preview test (Robin)
asana-task-description: The ADS Preview end to end workflow has failed. See https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}
include-tags: androidDesignSystemTest
15 changes: 2 additions & 13 deletions .github/workflows/custom-tabs-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
uses: actions/checkout@v4
with:
submodules: recursive
ref: 'feature/cris/on-activity-created-non-blocking'

- name: Set up JDK version
uses: actions/setup-java@v4
Expand Down Expand Up @@ -65,16 +66,4 @@ jobs:
app-file: apk/release.apk
android-api-level: 30
workspace: .maestro
include-tags: customTabsTest

- name: Create Asana task when workflow failed
if: ${{ failure() }}
id: create-failure-task
uses: duckduckgo/native-github-asana-sync@v2.0
with:
asana-pat: ${{ secrets.ASANA_ACCESS_TOKEN }}
asana-project: ${{ vars.GH_ANDROID_APP_PROJECT_ID }}
asana-section: ${{ vars.GH_ANDROID_APP_INCOMING_SECTION_ID }}
asana-task-name: GH Workflow Failure - Custom Tabs Flows (Robin)
asana-task-description: The Custom Tabs nightly workflow has failed. See https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}
action: 'create-asana-task'
include-tags: customTabsTest
1 change: 1 addition & 0 deletions .github/workflows/design-system-composable-pr-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
uses: actions/checkout@v4
with:
submodules: recursive
ref: 'feature/cris/on-activity-created-non-blocking'

- name: Set up JDK version
uses: actions/setup-java@v4
Expand Down
14 changes: 2 additions & 12 deletions .github/workflows/duckplayer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
uses: actions/checkout@v4
with:
submodules: recursive
ref: 'feature/cris/on-activity-created-non-blocking'

- name: Set up JDK version
uses: actions/setup-java@v4
Expand Down Expand Up @@ -76,15 +77,4 @@ jobs:
app-file: apk/internal.apk
android-api-level: 34
workspace: .maestro
include-tags: duckplayer

- name: Create Asana task when workflow failed
if: ${{ failure() && github.event_name != 'workflow_dispatch' }}
uses: honeycombio/gha-create-asana-task@main
with:
asana-secret: ${{ secrets.ASANA_ACCESS_TOKEN }}
asana-workspace-id: ${{ secrets.GH_ASANA_WORKSPACE_ID }}
asana-project-id: ${{ secrets.DUCK_PLAYER_AOR_PROJECT_ID }}
asana-section-id: ${{ secrets.DUCK_PLAYER_AOR_INCOMING_ID }}
asana-task-name: GH Workflow Failure - Duck Player tests
asana-task-description: The Duck Player workflow has failed. See https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}
include-tags: duckplayer
15 changes: 2 additions & 13 deletions .github/workflows/e2e-nightly-autofill.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
uses: actions/checkout@v4
with:
submodules: recursive
ref: 'feature/cris/on-activity-created-non-blocking'

- name: Set up JDK version
uses: actions/setup-java@v4
Expand Down Expand Up @@ -78,16 +79,4 @@ jobs:
app-file: apk/release.apk
android-api-level: 30
workspace: .maestro
include-tags: autofillBackfillingUsername,autofillPasswordGeneration

- name: Create Asana task when workflow failed
if: ${{ failure() }}
id: create-failure-task
uses: duckduckgo/native-github-asana-sync@v2.0
with:
asana-pat: ${{ secrets.ASANA_ACCESS_TOKEN }}
asana-project: ${{ vars.GH_ANDROID_APP_PROJECT_ID }}
asana-section: ${{ vars.GH_ANDROID_APP_INCOMING_SECTION_ID }}
asana-task-name: GH Workflow Failure - Autofill E2E Flows (Robin)
asana-task-description: Autofill tests have failed. See https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}
action: 'create-asana-task'
include-tags: autofillBackfillingUsername,autofillPasswordGeneration
14 changes: 2 additions & 12 deletions .github/workflows/end-to-end-robintest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
uses: actions/checkout@v4
with:
submodules: recursive
ref: 'feature/cris/on-activity-created-non-blocking'

- name: Set up JDK version
uses: actions/setup-java@v4
Expand Down Expand Up @@ -155,15 +156,4 @@ jobs:
app-file: apk/release.apk
android-api-level: 33
workspace: .maestro
include-tags: permissionsTest

- name: Create Asana task when workflow failed
if: ${{ failure() }}
uses: honeycombio/gha-create-asana-task@main
with:
asana-secret: ${{ secrets.ASANA_ACCESS_TOKEN }}
asana-workspace-id: ${{ secrets.GH_ASANA_WORKSPACE_ID }}
asana-project-id: ${{ secrets.GH_ASANA_AOR_PROJECT_ID }}
asana-section-id: ${{ secrets.GH_ASANA_INCOMING_ID }}
asana-task-name: GH Workflow Failure - End to end tests (Robin)
asana-task-description: The end to end workflow has failed. See https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}
include-tags: permissionsTest
14 changes: 2 additions & 12 deletions .github/workflows/input-screen-e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
uses: actions/checkout@v4
with:
submodules: recursive
ref: 'feature/cris/on-activity-created-non-blocking'

- name: Set up JDK version
uses: actions/setup-java@v4
Expand Down Expand Up @@ -63,15 +64,4 @@ jobs:
app-file: apk/playRelease.apk
android-api-level: 30
workspace: .maestro
include-tags: inputScreenTest

- name: Create Asana task when workflow failed
if: ${{ failure() }}
uses: honeycombio/gha-create-asana-task@main
with:
asana-secret: ${{ secrets.ASANA_ACCESS_TOKEN }}
asana-workspace-id: ${{ secrets.GH_ASANA_WORKSPACE_ID }}
asana-project-id: ${{ secrets.GH_ASANA_AOR_PROJECT_ID }}
asana-section-id: ${{ secrets.GH_ASANA_INCOMING_ID }}
asana-task-name: GH Workflow Failure - Input Screen E2E tests
asana-task-description: The Input Screen end-to-end workflow has failed. See https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}
include-tags: inputScreenTest
14 changes: 2 additions & 12 deletions .github/workflows/privacy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
uses: actions/checkout@v4
with:
submodules: recursive
ref: 'feature/cris/on-activity-created-non-blocking'

- name: Setup jq
uses: dcarbone/install-jq-action@v1.0.1
Expand Down Expand Up @@ -78,15 +79,4 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: android-tests-report
path: android-tests-report.zip

- name: Create Asana task when workflow failed
if: ${{ failure() && github.event_name != 'workflow_dispatch' }}
uses: honeycombio/gha-create-asana-task@main
with:
asana-secret: ${{ secrets.ASANA_ACCESS_TOKEN }}
asana-workspace-id: ${{ secrets.GH_ASANA_WORKSPACE_ID }}
asana-project-id: ${{ secrets.GH_ASANA_AOR_PROJECT_ID }}
asana-section-id: ${{ secrets.GH_ASANA_INCOMING_ID }}
asana-task-name: GH Workflow Failure - Privacy tests
asana-task-description: The privacy workflow has failed. See https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}
path: android-tests-report.zip
65 changes: 1 addition & 64 deletions .github/workflows/release_tests.yml
View file
Open in desktop
Copy link
Collaborator

@daxmobile daxmobile Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:45:45: Double quote to prevent globbing and word splitting [shellcheck]

Android/.github/workflows/release_tests.yml

Line 82 in d436728

run: |

Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
uses: actions/checkout@v4
with:
submodules: recursive
ref: ${{ github.event.inputs.app-version }}
ref: 'feature/cris/on-activity-created-non-blocking'

- name: Set up JDK version
uses: actions/setup-java@v4
Expand Down Expand Up @@ -63,16 +63,6 @@ jobs:
if: always()
run: find . -name "*.apk" -exec mv '{}' apk/release.apk \;

- name: Notify Mattermost of Maestro tests
id: send-mm-tests-started
uses: duckduckgo/native-github-asana-sync@v2.0
with:
mattermost-token: ${{ secrets.MM_AUTH_TOKEN }}
mattermost-team-id: ${{ secrets.MM_TEAM_ID }}
mattermost-channel-name: ${{ vars.MM_RELEASE_NOTIFY_CHANNEL }}
mattermost-message: ${{env.emoji_info}} Release ${{ github.event.inputs.app-version }}. Running Maestro tests for tag ${{ github.event.inputs.test-tag }} https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}
action: 'send-mattermost-message'

- name: Maestro tests flows
id: release-tests
uses: mobile-dev-inc/action-maestro-cloud@v1.9.8
Expand Down Expand Up @@ -143,56 +133,3 @@ jobs:
echo 'Flow Results (JSON): ${{ steps.release-tests.outputs.MAESTRO_CLOUD_FLOW_RESULTS }}'
echo "Release Tests Step Conclusion: ${{ steps.release-tests.conclusion }}" # From Maestro action itself
echo "Analyzed Flow Summary Status: ${{ steps.analyze-flow-results.outputs.flow_summary_status }}" # From our script

- name: Notify Mattermost - Maestro Tests ALL SUCCEEDED
# Condition 1: Our script says success
# Condition 2: The Maestro action itself also reported overall success
if: always() && steps.analyze-flow-results.outputs.flow_summary_status == 'success' && steps.release-tests.conclusion == 'success'
uses: duckduckgo/native-github-asana-sync@v2.0
with:
action: 'send-mattermost-message'
mattermost-token: ${{ secrets.MM_AUTH_TOKEN }}
mattermost-team-id: ${{ secrets.MM_TEAM_ID }}
mattermost-channel-name: ${{ vars.MM_RELEASE_NOTIFY_CHANNEL }}
mattermost-message: |
${{env.emoji_success}} Release ${{ github.event.inputs.app-version }}: Tests for tag ${{ github.event.inputs.test-tag }} PASSED successfully.
Console: ${{ steps.release-tests.outputs.MAESTRO_CLOUD_CONSOLE_URL }}

- name: Notify Mattermost - Maestro Tests FAILURES or ISSUES DETECTED
# Condition: Our script detected 'failure' OR the Maestro action itself reported failure
if: always() && (steps.analyze-flow-results.outputs.flow_summary_status == 'failure' || steps.release-tests.conclusion == 'failure')
uses: duckduckgo/native-github-asana-sync@v2.0
with:
action: 'send-mattermost-message'
mattermost-token: ${{ secrets.MM_AUTH_TOKEN }}
mattermost-team-id: ${{ secrets.MM_TEAM_ID }}
mattermost-channel-name: ${{ vars.MM_RELEASE_NOTIFY_CHANNEL }}
mattermost-message: |
${{env.emoji_failure}} Release ${{ github.event.inputs.app-version }}: Tests for tag ${{ github.event.inputs.test-tag }} FAILED or encountered issues.
Console: ${{ steps.release-tests.outputs.MAESTRO_CLOUD_CONSOLE_URL }}

- name: Notify Mattermost - Maestro Tests CANCELED Flows Present (Informational or Warning)
# Condition: Our script detected 'canceled_present' AND no critical 'failure' was found
# AND Maestro action itself didn't mark the whole run as a 'failure'
if: always() && steps.analyze-flow-results.outputs.flow_summary_status == 'canceled_present' && steps.release-tests.conclusion != 'failure'
uses: duckduckgo/native-github-asana-sync@v2.0
with:
action: 'send-mattermost-message'
mattermost-token: ${{ secrets.MM_AUTH_TOKEN }}
mattermost-team-id: ${{ secrets.MM_TEAM_ID }}
mattermost-channel-name: ${{ vars.MM_RELEASE_NOTIFY_CHANNEL }}
mattermost-message: |
:warning: Release ${{ github.event.inputs.app-version }}: Some tests for tag ${{ github.event.inputs.test-tag }} were CANCELED. Please review.
Console: ${{ steps.release-tests.outputs.MAESTRO_CLOUD_CONSOLE_URL }}

- name: Create Asana task when workflow failed
if: ${{ failure() }}
id: create-failure-task
uses: duckduckgo/native-github-asana-sync@v2.0
with:
asana-pat: ${{ secrets.ASANA_ACCESS_TOKEN }}
asana-project: ${{ vars.GH_ANDROID_APP_PROJECT_ID }}
asana-section: ${{ vars.GH_ANDROID_APP_INCOMING_SECTION_ID }}
asana-task-name: GH Workflow Failure - Tag Android Release (Robin)
asana-task-description: Run Release Tests in Maestro has failed. See https://github.com/duckduckgo/Android/actions/runs/${{ github.run_id }}
action: 'create-asana-task'
2 changes: 1 addition & 1 deletion app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7839,7 +7839,7 @@ class BrowserTabViewModelTest {
class FakeCustomHeadersProvider(
var headers: Map<String, String>,
) : CustomHeadersProvider {
override fun getCustomHeaders(url: String): Map<String, String> = headers
override suspend fun getCustomHeaders(url: String): Map<String, String> = headers
}

class FakeContentScopeScriptsSubscriptionEventPlugin(
Expand Down
Loading
Loading