Skip to content

Feat/bind support for rust_decimal::Decimal #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feat/bind support for rust_decimal::Decimal #634

wants to merge 4 commits into from
+155 −2

Conversation

@destinyFvcker
Copy link

@destinyFvcker destinyFvcker commented Nov 22, 2025

  • Handle ValueRef::Decimal(d) in statement.rs + tests
  • Handle ValueRef::Decimal(d) in appender/mod.rs + tests
  • impl FromSql for rust_decimal::Decimal in from_sql.rs
  • impl ToSql for rust_decimal::Decimal in to_sql.rs

Since there is no C-API for duckdb_append_decimal, duckdb_append_value is used as a substitute.

@destinyFvcker destinyFvcker mentioned this pull request Nov 22, 2025
Open
@PeterlitsZo
Copy link

PeterlitsZo commented Nov 23, 2025

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@destinyFvcker @PeterlitsZo