program: let anotehr signer deposit on user behalf #1891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphan
reviewed
Sep 18, 2025
| let signer = if ctx.accounts.authority.key() == user.authority { | ||
| Some(ctx.accounts.authority.key()) | ||
| } else { | ||
| None |
Member
There was a problem hiding this comment.
should this just always be ctx.accounts.authority? i guess that would make all events larger
Member
There was a problem hiding this comment.
prefer keeping it None for normal deposit to match historical schema
wphan
reviewed
Sep 18, 2025
| } else { | ||
| DepositExplanation::None | ||
| }; | ||
| let signer = if ctx.accounts.authority.key() == user.authority { |
Member
There was a problem hiding this comment.
i think you want to flip this and log if it's a third party making the deposit?
Suggested change
| let signer = if ctx.accounts.authority.key() == user.authority { | |
| let signer = if ctx.accounts.authority.key() != user.authority { |
Member
There was a problem hiding this comment.
should this be a newly named instruction to lower chance of accidental deposit into wrong account?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.