Skip to content

Conversation

@ljmay168
Copy link
Contributor

@ljmay168 ljmay168 commented Nov 26, 2025

Link issues

fixes #7176
因电脑上未安装最新的VS, 同步了最新的源码运行不了,写的PR没有测试,如有发现问题请帮忙修改

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Fix table column drag-and-drop behavior after toggling column visibility by resetting drag listeners when columns are shown again.

Bug Fixes:

  • Ensure draggable table columns reinitialize drag-and-drop handlers when a previously hidden column is made visible.
  • Clear existing drag event handlers before re-binding them on table header cells to prevent inconsistent drag behavior.

@bb-auto
Copy link

bb-auto bot commented Nov 26, 2025

Thanks for your PR, @ljmay168. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 26, 2025

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Nov 26, 2025
@bb-auto bb-auto bot requested a review from ArgoZhang November 26, 2025 01:55
@bb-auto bb-auto bot added this to the 10.0.0 milestone Nov 26, 2025
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Nov 26, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b161e57) to head (7e71b20).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7180   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        32574     32583    +9     
  Branches      4513      4515    +2     
=========================================
+ Hits         32574     32583    +9     
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang changed the title fix(Table): 列被隐藏再取消隐藏后,拖动列改变列顺序的功能不正常 #7176 fix(Table): need reset columns after toggle visible #7176 Nov 26, 2025
@ArgoZhang ArgoZhang changed the title fix(Table): need reset columns after toggle visible #7176 fix(Table): reset columns after toggle visible #7176 Nov 26, 2025
@ArgoZhang ArgoZhang merged commit 985b612 into dotnetcore:main Nov 26, 2025
4 checks passed
@ArgoZhang ArgoZhang changed the title fix(Table): reset columns after toggle visible #7176 fix(Table): reset columns after toggle visible Nov 26, 2025
ArgoZhang added a commit that referenced this pull request Nov 26, 2025
* fix(Table): 列被隐藏再取消隐藏后,拖动列改变列顺序的功能不正常 #7176

* refactor: 复用脚本

* test: 更新单元测试

* test: 重构单元测试

---------

Co-Authored-By: ljmay168 <209402714+ljmay168@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(Table): 列被隐藏再取消隐藏后,拖动列改变列顺序的功能不正常

2 participants