Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 8, 2025

Note

This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

  • From 10.0.0-rtm.25520.117 to 10.0.1-servicing.25555.106
    • dotnet-dev-certs
    • dotnet-user-jwts
    • dotnet-user-secrets
    • Microsoft.AspNetCore.Analyzers
    • Microsoft.AspNetCore.App.Ref.Internal
    • Microsoft.AspNetCore.Components.SdkAnalyzers
    • Microsoft.AspNetCore.DeveloperCertificates.XPlat
    • Microsoft.AspNetCore.Mvc.Analyzers
    • Microsoft.AspNetCore.Mvc.Api.Analyzers
    • Microsoft.NET.HostModel
    • Microsoft.NET.Sdk.WindowsDesktop
    • Microsoft.NETCore.Platforms
    • Microsoft.WindowsDesktop.App.Internal
  • From 10.0.0 to 10.0.1
    • Microsoft.AspNetCore.App.Ref
    • Microsoft.AspNetCore.Authentication.Facebook
    • Microsoft.AspNetCore.Authentication.Google
    • Microsoft.AspNetCore.Authentication.MicrosoftAccount
    • Microsoft.AspNetCore.Authorization
    • Microsoft.AspNetCore.Components
    • Microsoft.AspNetCore.Components.Analyzers
    • Microsoft.AspNetCore.Components.Forms
    • Microsoft.AspNetCore.Components.Web
    • Microsoft.AspNetCore.Components.WebAssembly
    • Microsoft.AspNetCore.Components.WebAssembly.Server
    • Microsoft.AspNetCore.Components.WebView
    • Microsoft.AspNetCore.Metadata
    • Microsoft.AspNetCore.TestHost
    • Microsoft.Bcl.AsyncInterfaces
    • Microsoft.DotNet.Web.ItemTemplates.10.0
    • Microsoft.DotNet.Web.ProjectTemplates.10.0
    • Microsoft.Extensions.Configuration.Ini
    • Microsoft.Extensions.DependencyModel
    • Microsoft.Extensions.FileProviders.Abstractions
    • Microsoft.Extensions.FileProviders.Embedded
    • Microsoft.Extensions.FileSystemGlobbing
    • Microsoft.Extensions.Logging
    • Microsoft.Extensions.Logging.Abstractions
    • Microsoft.Extensions.Logging.Console
    • Microsoft.Extensions.ObjectPool
    • Microsoft.JSInterop
    • Microsoft.NET.ILLink.Tasks
    • Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.win-x64
    • Microsoft.NETCore.App.Ref
    • Microsoft.Win32.SystemEvents
    • Microsoft.WindowsDesktop.App.Ref
    • System.CodeDom
    • System.ComponentModel.Composition
    • System.Composition.AttributedModel
    • System.Composition.Convention
    • System.Composition.Hosting
    • System.Composition.Runtime
    • System.Composition.TypedParts
    • System.Configuration.ConfigurationManager
    • System.Diagnostics.DiagnosticSource
    • System.Formats.Asn1
    • System.IO.Hashing
    • System.Reflection.MetadataLoadContext
    • System.Resources.Extensions
    • System.Security.Cryptography.Pkcs
    • System.Security.Cryptography.ProtectedData
    • System.Security.Cryptography.Xml
    • System.Security.Permissions
    • System.ServiceProcess.ServiceController
    • System.Text.Encoding.CodePages
    • System.Text.Json
    • System.Windows.Extensions
  • From 10.0.0-preview.25520.117 to 10.0.0-preview.25555.106
    • Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal
    • Microsoft.CodeAnalysis.Razor.Tooling.Internal
    • Microsoft.NET.Sdk.Razor.SourceGenerators.Transport
  • From 18.0.0 to 18.0.3
    • Microsoft.Build
  • From 18.0.0-servicing-25520-117 to 18.0.3-servicing-25555-106
    • Microsoft.Build.Localization
  • From 7.0.0-rc.2117 to 7.0.0-rc.5606
    • Microsoft.Build.NuGetSdkResolver
    • NuGet.Build.Tasks
    • NuGet.Build.Tasks.Console
    • NuGet.Build.Tasks.Pack
    • NuGet.CommandLine.XPlat
    • NuGet.Commands
    • NuGet.Common
    • NuGet.Configuration
    • NuGet.Credentials
    • NuGet.DependencyResolver.Core
    • NuGet.Frameworks
    • NuGet.LibraryModel
    • NuGet.Localization
    • NuGet.Packaging
    • NuGet.ProjectModel
    • NuGet.Protocol
    • NuGet.Versioning
  • From 10.0.0-beta.25520.117 to 10.0.0-beta.25555.106
    • Microsoft.Build.Tasks.Git
    • Microsoft.DotNet.Arcade.Sdk
    • Microsoft.DotNet.Build.Tasks.Installers
    • Microsoft.DotNet.Build.Tasks.Templating
    • Microsoft.DotNet.Build.Tasks.Workloads
    • Microsoft.DotNet.Helix.Sdk
    • Microsoft.DotNet.SignTool
    • Microsoft.DotNet.XliffTasks
    • Microsoft.DotNet.XUnitExtensions
    • Microsoft.SourceLink.AzureRepos.Git
    • Microsoft.SourceLink.Bitbucket.Git
    • Microsoft.SourceLink.Common
    • Microsoft.SourceLink.GitHub
    • Microsoft.SourceLink.GitLab
  • From 5.0.0-2.25520.117 to 5.0.0-2.25555.106
    • Microsoft.CodeAnalysis
    • Microsoft.CodeAnalysis.BuildClient
    • Microsoft.CodeAnalysis.CSharp
    • Microsoft.CodeAnalysis.CSharp.CodeStyle
    • Microsoft.CodeAnalysis.CSharp.Features
    • Microsoft.CodeAnalysis.CSharp.Workspaces
    • Microsoft.CodeAnalysis.PublicApiAnalyzers
    • Microsoft.CodeAnalysis.Workspaces.Common
    • Microsoft.CodeAnalysis.Workspaces.MSBuild
    • Microsoft.Net.Compilers.Toolset
    • Microsoft.Net.Compilers.Toolset.Framework
  • From 2.0.0-preview.1.25520.117 to 2.0.0-preview.1.25555.106
    • Microsoft.Deployment.DotNet.Releases
  • From 2.2.0-beta.25520.117 to 2.2.0-beta.25555.106
    • Microsoft.DiaSymReader
  • From 14.0.100-rc2.25520.117 to 14.0.101-servicing.25555.106
    • Microsoft.FSharp.Compiler
  • From 18.0.1-release-25520-117 to 18.0.1-release-25555-106
    • Microsoft.NET.Test.Sdk
    • Microsoft.TestPlatform.Build
    • Microsoft.TestPlatform.CLI
  • From 10.0.100 to 10.0.101
    • Microsoft.TemplateEngine.Abstractions
    • Microsoft.TemplateEngine.Authoring.TemplateVerifier
    • Microsoft.TemplateEngine.Edge
    • Microsoft.TemplateEngine.Orchestrator.RunnableProjects
    • Microsoft.TemplateEngine.Utils
    • Microsoft.TemplateSearch.Common
  • From 10.0.100-rtm.25520.117 to 10.0.101-servicing.25555.106
    • Microsoft.TemplateEngine.Mocks
    • Microsoft.TemplateEngine.TestHelper
    • Microsoft.TemplateSearch.TemplateDiscovery
  • From 3.2.0-preview.25520.117 to 3.2.0-preview.25555.106
    • Microsoft.Web.Xdt
  • From 2.0.0 to 2.0.1
    • System.CommandLine

Associated changes in source repos

Updated Dependencies:
dotnet-dev-certs, dotnet-user-jwts, dotnet-user-secrets, Microsoft.AspNetCore.Analyzers, Microsoft.AspNetCore.App.Ref.Internal, Microsoft.AspNetCore.Components.SdkAnalyzers, Microsoft.AspNetCore.DeveloperCertificates.XPlat, Microsoft.AspNetCore.Mvc.Analyzers, Microsoft.AspNetCore.Mvc.Api.Analyzers, Microsoft.NET.HostModel, Microsoft.NET.Sdk.WindowsDesktop, Microsoft.NETCore.Platforms, Microsoft.WindowsDesktop.App.Internal (Version 10.0.0-rtm.25520.117 -> 10.0.1-servicing.25555.106)
Microsoft.AspNetCore.App.Ref, Microsoft.AspNetCore.Authentication.Facebook, Microsoft.AspNetCore.Authentication.Google, Microsoft.AspNetCore.Authentication.MicrosoftAccount, Microsoft.AspNetCore.Authorization, Microsoft.AspNetCore.Components, Microsoft.AspNetCore.Components.Analyzers, Microsoft.AspNetCore.Components.Forms, Microsoft.AspNetCore.Components.Web, Microsoft.AspNetCore.Components.WebAssembly, Microsoft.AspNetCore.Components.WebAssembly.Server, Microsoft.AspNetCore.Components.WebView, Microsoft.AspNetCore.Metadata, Microsoft.AspNetCore.TestHost, Microsoft.Bcl.AsyncInterfaces, Microsoft.DotNet.Web.ItemTemplates.10.0, Microsoft.DotNet.Web.ProjectTemplates.10.0, Microsoft.Extensions.Configuration.Ini, Microsoft.Extensions.DependencyModel, Microsoft.Extensions.FileProviders.Abstractions, Microsoft.Extensions.FileProviders.Embedded, Microsoft.Extensions.FileSystemGlobbing, Microsoft.Extensions.Logging, Microsoft.Extensions.Logging.Abstractions, Microsoft.Extensions.Logging.Console, Microsoft.Extensions.ObjectPool, Microsoft.JSInterop, Microsoft.NET.ILLink.Tasks, Microsoft.NET.Runtime.Emscripten.3.1.56.Cache.win-x64, Microsoft.NETCore.App.Ref, Microsoft.Win32.SystemEvents, Microsoft.WindowsDesktop.App.Ref, System.CodeDom, System.ComponentModel.Composition, System.Composition.AttributedModel, System.Composition.Convention, System.Composition.Hosting, System.Composition.Runtime, System.Composition.TypedParts, System.Configuration.ConfigurationManager, System.Diagnostics.DiagnosticSource, System.Formats.Asn1, System.IO.Hashing, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Security.Cryptography.Pkcs, System.Security.Cryptography.ProtectedData, System.Security.Cryptography.Xml, System.Security.Permissions, System.ServiceProcess.ServiceController, System.Text.Encoding.CodePages, System.Text.Json, System.Windows.Extensions (Version 10.0.0 -> 10.0.1)
Microsoft.AspNetCore.Mvc.Razor.Extensions.Tooling.Internal, Microsoft.CodeAnalysis.Razor.Tooling.Internal, Microsoft.NET.Sdk.Razor.SourceGenerators.Transport (Version 10.0.0-preview.25520.117 -> 10.0.0-preview.25555.106)
Microsoft.Build (Version 18.0.0 -> 18.0.3)
Microsoft.Build.Localization (Version 18.0.0-servicing-25520-117 -> 18.0.3-servicing-25555-106)
Microsoft.Build.NuGetSdkResolver, NuGet.Build.Tasks, NuGet.Build.Tasks.Console, NuGet.Build.Tasks.Pack, NuGet.CommandLine.XPlat, NuGet.Commands, NuGet.Common, NuGet.Configuration, NuGet.Credentials, NuGet.DependencyResolver.Core, NuGet.Frameworks, NuGet.LibraryModel, NuGet.Localization, NuGet.Packaging, NuGet.ProjectModel, NuGet.Protocol, NuGet.Versioning (Version 7.0.0-rc.2117 -> 7.0.0-rc.5606)
Microsoft.Build.Tasks.Git, Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.SignTool, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.Bitbucket.Git, Microsoft.SourceLink.Common, Microsoft.SourceLink.GitHub, Microsoft.SourceLink.GitLab (Version 10.0.0-beta.25520.117 -> 10.0.0-beta.25555.106)
Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.BuildClient, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.CSharp.CodeStyle, Microsoft.CodeAnalysis.CSharp.Features, Microsoft.CodeAnalysis.CSharp.Workspaces, Microsoft.CodeAnalysis.PublicApiAnalyzers, Microsoft.CodeAnalysis.Workspaces.Common, Microsoft.CodeAnalysis.Workspaces.MSBuild, Microsoft.Net.Compilers.Toolset, Microsoft.Net.Compilers.Toolset.Framework (Version 5.0.0-2.25520.117 -> 5.0.0-2.25555.106)
Microsoft.Deployment.DotNet.Releases (Version 2.0.0-preview.1.25520.117 -> 2.0.0-preview.1.25555.106)
Microsoft.DiaSymReader (Version 2.2.0-beta.25520.117 -> 2.2.0-beta.25555.106)
Microsoft.FSharp.Compiler (Version 14.0.100-rc2.25520.117 -> 14.0.101-servicing.25555.106)
Microsoft.NET.Test.Sdk, Microsoft.TestPlatform.Build, Microsoft.TestPlatform.CLI (Version 18.0.1-release-25520-117 -> 18.0.1-release-25555-106)
Microsoft.TemplateEngine.Abstractions, Microsoft.TemplateEngine.Authoring.TemplateVerifier, Microsoft.TemplateEngine.Edge, Microsoft.TemplateEngine.Orchestrator.RunnableProjects, Microsoft.TemplateEngine.Utils, Microsoft.TemplateSearch.Common (Version 10.0.100 -> 10.0.101)
Microsoft.TemplateEngine.Mocks, Microsoft.TemplateEngine.TestHelper, Microsoft.TemplateSearch.TemplateDiscovery (Version 10.0.100-rtm.25520.117 -> 10.0.101-servicing.25555.106)
Microsoft.Web.Xdt (Version 3.2.0-preview.25520.117 -> 3.2.0-preview.25555.106)
System.CommandLine (Version 2.0.0 -> 2.0.1)
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner November 8, 2025 02:02
@DonnaChen888
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@DonnaChen888
Copy link
Contributor

@nagilson Could you please help me to take a look at this issue?

@dsplaisted
Copy link
Member

@jjonescz There are three failing run file tests. Could you take a look at them?

@jjonescz
Copy link
Member

jjonescz commented Nov 13, 2025

There seems to be some mismatch in the redist sdk here. My test just catches that mismatch.

  • When building a simple console app, the generated runtimeconfig.json contains "version": "10.0.0".
  • RuntimeInformation.FrameworkDescription inside sdk CLI is 10.0.1.

That's how the test fails (it expects both of those to match), but I can see many occurrences of both 10.0.0 and 10.0.1 versions in the binlog of building a simple console app with the redist sdk from this branch. That seems suspicious to me.

If it is expected that these versions are mismatched, I'd like to know how can I obtain the "10.0.0" version from inside the sdk CLI (if not via RuntimeInformation.FrameworkDescription) so I can fixup the failure.

If it is not expected, please consider adding a test specifically for this, so it's not just my run-file tests that catch this.

@dsplaisted
Copy link
Member

@jjonescz This is expected. When you build a framework-dependent app, it does not depend on the latest patch of the runtime. That's what's expressed in the runtimeconfig file. The reason for this is that we don't want you to update the .NET SDK, build and deploy an app, and have that app fail to run because the target environment hasn't installed the latest patch yet.

At runtime, it does roll forward to the latest installed patch of the .NET runtime. That's_ what you're getting from the FrameworkDescription. See https://learn.microsoft.com/en-us/dotnet/core/versions/selection#framework-dependent-apps-roll-forward.

What is the test trying to validate by comparing those versions?

@jjonescz
Copy link
Member

What is the test trying to validate by comparing those versions?

The test is validating that a manual csc execution (which is used during an optimized compilation of a file-based app) generates the same runtimeconfig.json as MSBuild would.

The manual csc execution (CSharpCompilerCommand) uses RuntimeInformation.FrameworkDescription to fill in the "version" of the runtimeconfig.json file:

"version": {{JsonSerializer.Serialize(RuntimeVersion)}}

Do you know if there is another property available in the dotnet.dll that the CSharpCompilerCommand could use to emit the same version as MSBuild would?

@dotnet-maestro
Copy link
Contributor Author

Important

The source repository has received code changes from an opposite flow. Any additional codeflows into this PR may potentially result in lost changes.

Please continue with one of the following options:

  1. Close or merge this PR and let the codeflow continue normally
  2. Close or merge this PR and receive the new codeflow immediately by triggering the subscription:
    darc trigger-subscriptions --id a6e017f9-bb8f-4e92-9b9b-01e2a6e340e2
  3. Force-flow new changes into this PR at your own risk (some PR commits might be reverted):
    darc trigger-subscriptions --force --id a6e017f9-bb8f-4e92-9b9b-01e2a6e340e2

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dsplaisted
Copy link
Member

Do you know if there is another property available in the dotnet.dll that the CSharpCompilerCommand could use to emit the same version as MSBuild would?

@jjonescz I don't think so. There's a lot of MSBuild logic that goes into determining this. Some of it is described here. It involves the TargetLatestRuntimePatch property, and then the ProcessFrameworkReferences task selects either the value from the DefaultRuntimeFrameworkVersion or the 10.0.0-rc.2.25502.107 metadata of the matching KnownFrameworkReference item.

You may be able to set the patch version to 0 if the FrameworkDescription version is a non-preview version to mirror what happens in MSBuild.

@jjonescz
Copy link
Member

Yep, I've tried to replicate the logic in the last commit. Feel free to give it a review :)

@dsplaisted dsplaisted merged commit d6a4c47 into release/10.0.1xx Nov 18, 2025
27 checks passed
@dsplaisted dsplaisted deleted the darc-release/10.0.1xx-93f43bbb-dd87-4769-b38b-cfa19e71f296 branch November 18, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants