Move StubHelpers.AsyncCallContinuation to AsyncHelpers. #121458
+18
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtschuster
requested review from
MichalStrehovsky,
VSadov,
Copilot,
jakobbotsch and
jkotas
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the AsyncCallContinuation intrinsic from StubHelpers to AsyncHelpers, consolidating async-related functionality in a single location.
- The intrinsic method is relocated from
System.StubHelperstoSystem.Runtime.CompilerServices.AsyncHelpers - Corresponding updates made across VM metadata definitions, JIT intrinsic lists, and JIT importer logic
- Documentation updated to reflect the new location
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/corelib.h | Moved method definition from STUBHELPERS to ASYNC_HELPERS class |
| src/coreclr/jit/namedintrinsiclist.h | Moved intrinsic enum from StubHelpers section to AsyncHelpers section |
| src/coreclr/jit/importercalls.cpp | Updated intrinsic references and lookup logic to use AsyncHelpers |
| src/coreclr/jit/gentree.cpp | Updated comment to reference AsyncHelpers instead of StubHelpers |
| src/coreclr/System.Private.CoreLib/src/System/StubHelpers.cs | Removed AsyncCallContinuation method |
| src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs | Added AsyncCallContinuation method |
VSadov
reviewed
Nov 7, 2025
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs
Show resolved
Hide resolved
…Services/AsyncHelpers.CoreCLR.cs Co-authored-by: Vladimir Sadov <vsadov@microsoft.com>
This was referenced Nov 8, 2025
jkotas
reviewed
Nov 8, 2025
src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncHelpers.CoreCLR.cs
Outdated
Show resolved
Hide resolved
…Services/AsyncHelpers.CoreCLR.cs
jkotas
reviewed
Nov 8, 2025
| DEFINE_METHOD(ASYNC_HELPERS, RESTORE_CONTEXTS, RestoreContexts, NoSig) | ||
| DEFINE_METHOD(ASYNC_HELPERS, CAPTURE_CONTEXTS, CaptureContexts, NoSig) | ||
| DEFINE_METHOD(ASYNC_HELPERS, RESTORE_CONTEXTS, RestoreContexts, NoSig) | ||
| DEFINE_METHOD(ASYNC_HELPERS, ASYNC_CALL_CONTINUATION, AsyncCallContinuation, SM_RetContinuation) |
Member
There was a problem hiding this comment.
Suggested change
| DEFINE_METHOD(ASYNC_HELPERS, ASYNC_CALL_CONTINUATION, AsyncCallContinuation, SM_RetContinuation) | |
| DEFINE_METHOD(ASYNC_HELPERS, ASYNC_CALL_CONTINUATION, AsyncCallContinuation, NoSig) |
So that it looks like the other methods.
The signature is only required to disambiguate overloads. Also, delete RetContinuation from metasig.h
jkotas
reviewed
Nov 8, 2025
| // This is the "magic" method on wich other "Await" methods are built. | ||
| // Calling this from an Async method returns the continuation to the caller thus | ||
| // explicitly initiates suspension. | ||
| [Intrinsic] |
Member
There was a problem hiding this comment.
There is a typo (wich -> which) a few lines above
jakobbotsch
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves StubHelpers.AsyncCallContinuation to AsyncHelpers so StubHelpers.cs doesn't need to be added to nativeaot.
Thought it would be good to have separate commits for this and the rest of #121456