-
Notifications
You must be signed in to change notification settings - Fork 832
Type checker: recover on adding constraints #19034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+707
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
❗ Release notes required
|
6bff61d to
0aef154
Compare
4b5f7bd to
be79b41
Compare
be79b41 to
4303465
Compare
Member
Author
|
This is ready. |
Member
Author
|
Update: I found an issue in this one, please don't merge it yet. |
T-Gro
requested changes
Nov 3, 2025
Member
T-Gro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To prevent merging.
Member
|
@auduchinok : Was this PR now superseded? |
Member
|
Closing as I understood #19046 solves this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds recovery to various cases where an error would break subsequent analysis.
In the following example
fwas not added to the environment, breaking analysis of its usages:In this example the
fargument is not analyzed at all: