Fix a doc details about loading Native DLLs #3310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoffeeFlux
approved these changes
Oct 8, 2019
- Note that `NativeLibrary.Load()` etc. must return the actual OS handle - Note that `AssemblyLoadContext.LoadUnmanagedDllFromPath()` also returns the OS handle (also fix its exceptions).
mairaw
requested changes
Oct 9, 2019
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
Thanks @swaroop-sridhar for your PR. Left a couple of suggestions.
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
bartonjs
approved these changes
Oct 9, 2019
Member
bartonjs
left a comment
bartonjs
left a comment
There was a problem hiding this comment.
Based on the comments in dotnet/coreclr#27090, seems good to me.
Contributor
Author
|
@mairaw I've applied the changes you suggested. Thanks. |
mairaw
approved these changes
Oct 11, 2019
Contributor
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
Thank you @swaroop-sridhar!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NativeLibrary.Load()etc. must return the actual OS handleAssemblyLoadContext.LoadUnmanagedDllFromPath()also returns the OS handle(also fix its exceptions).