[release/10.0] Enable Identity telemetry by instantiating metrics classes directly #64271
+53
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>
…able UserManagerMetrics registration Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
…ager Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
Hi @@github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64265 to release/10.0
/cc @JamesNK @copilot
Enable Identity telemetry by instantiating metrics classes directly
Change identity metrics to not require some types registered to DI.
Fixes #64264
Customer Impact
Identity metrics aren't working because they rely on some types being registered with DI. They were registered in tests, but not in real-world
AddIdentity()methods. It isn't possible for the user to register these types because they're internal.Changes in this PR:
AddMetrics()when identity types are added to DI.AddMetrics()should have been called by other code in the app (i.e. authentication, or hosting) but this changes ensures that's true.Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
When servicing release/2.3