-
-
Notifications
You must be signed in to change notification settings - Fork 440
[3.0] OpenAL Bindings #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop/3.0
Are you sure you want to change the base?
[3.0] OpenAL Bindings #2494
Conversation
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 52817a4 |
|
All native library builds modified in this PR shall attempt to be built by CI. |
|
All native library builds modified in this PR shall attempt to be built by CI. |
…et/Silk.NET into feature/openal-bindings-3.0
…et/Silk.NET into feature/openal-bindings-3.0
| OutOfMemory = unchecked((uint)0xA005), | ||
| StackOverflowEXT = unchecked((uint)0x19CD), | ||
| StackUnderflowEXT = unchecked((uint)0x19CE), | ||
| CNoError = unchecked((uint)0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put in a PR to fix this: kcat/openal-soft#1200
| EventTypeBufferCompleted = unchecked((uint)0x19A4), | ||
| EventTypeSourceStateChanged = unchecked((uint)0x19A5), | ||
| EventTypeDisconnected = unchecked((uint)0x19A6), | ||
| CEventTypeDefaultDeviceChanged = unchecked((uint)0x19D6), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've put in a PR to fix this: kcat/openal-soft#1200
| FormatRear8 = unchecked((uint)0x1207), | ||
| FormatRear16 = unchecked((uint)0x1208), | ||
| FormatRear32 = unchecked((uint)0x1209), | ||
| Format51Chn8 = unchecked((uint)0x120A), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we want to change the trimmer so that we trim even if the name would start with a number after trimming (and then add an X prefix as we've done elsewhere)?
…et/Silk.NET into feature/openal-bindings-3.0
|
Some of the native library builds modified in this PR were not referenced in the PR description. Please ensure that the PR description contains |
|
Ignore the bot, I have committed new CI-built binaries previously :) |
|
Ready for review. Note the outstanding question. |
Uses the OpenAL Soft XML registry and headers.
TODO: