add error for encrypted files #1969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mikeebowen
commented
Nov 4, 2025
mikeebowen
commented
- closes Read sensitivity labelled documents #1635
twsouthwick
previously approved these changes
Nov 4, 2025
twsouthwick
reviewed
Nov 4, 2025
Comment on lines
199
to
200
| byte[] oleSignature = { 0xD0, 0xCF, 0x11, 0xE0, 0xA1, 0xB1, 0x1A, 0xE1 }; | ||
| if (read == 8 && header.SequenceEqual(oleSignature)) |
Member
There was a problem hiding this comment.
Suggested change
| byte[] oleSignature = { 0xD0, 0xCF, 0x11, 0xE0, 0xA1, 0xB1, 0x1A, 0xE1 }; | |
| if (read == 8 && header.SequenceEqual(oleSignature)) | |
| if (read == 8 && header.SequenceEqual([ 0xD0, 0xCF, 0x11, 0xE0, 0xA1, 0xB1, 0x1A, 0xE1 ])) |
Member
There was a problem hiding this comment.
not a big deal and may make readability worse, but on some platforms it may prevent an allocation (that is probably not a big deal at all)
mikeebowen
force-pushed
the
issue-1635
branch
from
c250b83 to
6cc3591
Compare
mkaszewiak
approved these changes
Nov 10, 2025
tomjebo
approved these changes
Nov 11, 2025
mkaszewiak
approved these changes
Nov 11, 2025
mliotta
added a commit
to mliotta/Open-XML-SDK
that referenced
this pull request
Nov 11, 2025
Merging latest changes from upstream: - add error for encrypted files (dotnet#1969)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.