Skip to content

refactor: Review nullability of DoclingDocument #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2025
Merged

refactor: Review nullability of DoclingDocument #130

merged 1 commit into from
Dec 1, 2025
+132 −22

Conversation

@ThomasVitale
Copy link
Contributor

@ThomasVitale ThomasVitale commented Dec 1, 2025 •
edited
Loading

  • Review nullability of DoclingDocument and related APIs in ConvertDocumentResponse.
    • Based on the Docling API, ensure each nullable field is marked as @Nullable.
    • For collections, adopt the same pattern used in Docling Serve and Docling Client so that null collections are deserialised into empty collections.
    • For boolean, use base type instead of wrapper to ensure a false default as in the Docling Core API project.
    • For numerical properties, keep using wrappers as the defaults might change.
  • Use Docling Serve 1.9.0 as the default image to ensure compatibility covers up to the latest version.

Fixes gh-129

@ThomasVitale
refactor: Review nullability of DoclingDocument
020953f 
* Review nullability of DoclingDocument and related APIs in ConvertDocumentResponse.
* Use Docling Serve 1.9.0 as the default image to ensure compatibility covers the latest version.

Fixes gh-129

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

TestsPassed ✅SkippedFailed
Gradle Test Results (all modules & JDKs)336 ran336 passed0 skipped0 failed
TestResult
No test annotations available

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

@edeandrea edeandrea merged commit 358e267 into main Dec 1, 2025
21 checks passed
@edeandrea edeandrea deleted the gh-129 branch December 1, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edeandrea edeandrea edeandrea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review nullability of DoclingDocument

3 participants

@ThomasVitale @edeandrea