express Option.arg as sentinel-terminated slice #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we happen to know the slice obtained for an "optarg" will be zero-terminated, it seems reasonable to include this information in the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we happen to know the slice obtained for an "optarg" will be zero-terminated, it seems reasonable to include this information in the type.
I'm newer to Zig, so correct me if I'm wrong, but it seems to me that
[:0]const u8gives strictly more compile-time information than[]const u8without costing anything at runtime. In my case, it allowed me to use the returnedargdirectly with a system API imported from C.