Make use of Pathlib's "/" #2312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulgens
force-pushed
the
make-use-of-pathlib
branch
from
b754dbc to
e124084
Compare
ulgens
force-pushed
the
make-use-of-pathlib
branch
from
e124084 to
4659721
Compare
adamzap
reviewed
Nov 21, 2025
docs/models.py
Outdated
| "djangoproject", "static", "robots.docs.txt" | ||
| ) | ||
| robots_path = settings.BASE_DIR / "djangoproject" / "static" / "robots.docs.txt" | ||
| with open(str(robots_path)) as fh: |
Member
There was a problem hiding this comment.
Do you want to use robots_path.open here like you did in test_models.py?
Member
Author
There was a problem hiding this comment.
Yep. Resolved with the latest force push (diff)
ulgens
force-pushed
the
make-use-of-pathlib
branch
2 times, most recently
from
776ee4b to
c163034
Compare
bmispelon
approved these changes
Nov 21, 2025
Member
bmispelon
left a comment
bmispelon
left a comment
There was a problem hiding this comment.
This looks good, nice work! 🎸
I haven't tested it locally, but I'm willing to trust the CI.
ulgens
force-pushed
the
make-use-of-pathlib
branch
from
c163034 to
6ff4d4d
Compare
It provides a cleaner and easier to read experience, comparing to .joinpath()
ulgens
force-pushed
the
make-use-of-pathlib
branch
from
73ba309 to
33ac63b
Compare
adamzap
approved these changes
Nov 21, 2025
SaptakS
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from:
LOCALE_PATHSsetting #2213 (comment)It provides a cleaner experience and it's easier to read, comparing to
.joinpath()