Skip to content

Conversation

@keranbyge
Copy link

Adds a Fosstodon link (https://fosstodon.org/@django
) alongside the existing X/Twitter link on the fundraising thank-you page.
Matches the current HTML structure and styling.
Verified rendering locally.

@keranbyge
Copy link
Author

Hi ,
I’ve verified the changes locally and the pre-commit checks have passed.
The workflows are awaiting approval — just wanted to confirm if any further updates are needed.
Thank you!

@keranbyge
Copy link
Author

Thanks!

Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have X we can add also Blue Sky

@@ -0,0 +1,6 @@
<p>
Follow us on
<a href="https://x.com/djangoproject">@djangoproject</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://x.com/djangoproject">@djangoproject</a>
<a href="https://x.com/djangoproject">@djangoproject on X</a>

Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend adding tests for changes, note that this test fails:

diff --git a/fundraising/tests/test_views.py b/fundraising/tests/test_views.py
index aca9d859..d272d32b 100644
--- a/fundraising/tests/test_views.py
+++ b/fundraising/tests/test_views.py
@@ -170,6 +170,8 @@ class TestThankYou(TestCase):
     def test_template(self):
         response = self.client.get(self.url)
         self.assertTemplateUsed(response, "fundraising/thank-you.html")
+        self.assertContains(response, "Thank you for supporting the Django Project!")
+        self.assertContains(response, "@django on Fosstodon")

I believe you have updated the wrong template and perhaps wanted to update djangoproject/templates/fundraising/thank-you.html

@keranbyge
Copy link
Author

Hi ,

I updated the test cases as suggested. Now I'm trying to run the fundraising tests locally using SQLite, but I'm getting an error when the test database is created.

Command I used:
python manage.py test fundraising --settings=djangoproject.settings.local_test

Error:
OperationalError: unrecognized token ":"
It seems to be related to database setup for testing. I tried removing the test DB file and updated local_test.py, but the issue remains.

If you have any suggestions or guidance on how to properly run fundraising tests with SQLite, I'd really appreciate your help.

@keranbyge keranbyge requested a review from sarahboyce October 30, 2025 18:09
@sarahboyce
Copy link
Contributor

It might not be possible (or at least not easy) to test with SQLite as this project uses postgres. I use the docker setup following the instructions in the readme. Otherwise the readme instructions are suggesting setting up a postgres database

@keranbyge
Copy link
Author

Got it, thank you!
I’ll follow the Docker setup and run tests using PostgreSQL as recommended.
Will update once it's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants