-
-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Add uv-lock pre-commit hook to the project #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add uv-lock pre-commit hook to the project #329
Conversation
|
I think we now cover most of the pre-commit hooks. We can remove the following jobs from the workflow (In some other PR): Line 13:
Line 30:
Since we already set up the Pre-commit CI bot, it is handling these responsibilities. |
|
Let's avoid additional pre-commits? |
True, but I think we've covered most of them. |
|
Can I ask why I was requested to review this? It was very out of the blue for me! |
|
I agree with @cunla that this would be a chatty hook that will create too many PRs for this project. There are tons of pre-commit hooks out there, so we are nowhere near covering most of them. |
Hey network throttling bug in review section select drop down. (Network issue) |
|
I'm not even sure why a package should have a lock file |
Totally make sense. |
|
https://docs.astral.sh/uv/concepts/projects/layout/#the-lockfile I think we should close this PR as unneeded. |
|
No need for this pre-commit hook, as it relates to lock file updates only. |
Description
This PR adds the
uv-lockpre-commit hook.It automatically runs
uv lockbefore each commit so theuv.lockfile always stays updated whenever dependencies or metadata change.Reference
UV docs: pre-commit-uv-lock