Skip to content

Conversation

@DhavalGojiya
Copy link
Member

Description

This PR adds the uv-lock pre-commit hook.
It automatically runs uv lock before each commit so the uv.lock file always stays updated whenever dependencies or metadata change.

Reference

UV docs: pre-commit-uv-lock

@DhavalGojiya
Copy link
Member Author

I think we now cover most of the pre-commit hooks.

We can remove the following jobs from the workflow (In some other PR):

Line 13:


Line 30:

Since we already set up the Pre-commit CI bot, it is handling these responsibilities.

@cunla
Copy link
Member

cunla commented Nov 16, 2025

Let's avoid additional pre-commits?
the idea is to support developers when developing, not have it as an obstacle.

@DhavalGojiya
Copy link
Member Author

Let's avoid additional pre-commits? the idea is to support developers when developing, not have it as an obstacle.

True, but I think we've covered most of them.
I think we can go with this.

@nanorepublica
Copy link
Member

Can I ask why I was requested to review this? It was very out of the blue for me!

@cclauss
Copy link
Contributor

cclauss commented Nov 17, 2025

I agree with @cunla that this would be a chatty hook that will create too many PRs for this project.

There are tons of pre-commit hooks out there, so we are nowhere near covering most of them.

@DhavalGojiya
Copy link
Member Author

Can I ask why I was requested to review this? It was very out of the blue for me!

Hey network throttling bug in review section select drop down. (Network issue)
You can skip this. @nanorepublica

@amirreza8002
Copy link
Member

I'm not even sure why a package should have a lock file
it's not used in CI, as matrix will install different versions

@DhavalGojiya
Copy link
Member Author

I'm not even sure why a package should have a lock file it's not used in CI, as matrix will install different versions

Totally make sense.

@cclauss
Copy link
Contributor

cclauss commented Nov 17, 2025

https://docs.astral.sh/uv/concepts/projects/layout/#the-lockfile

I think we should close this PR as unneeded.

@DhavalGojiya
Copy link
Member Author

No need for this pre-commit hook, as it relates to lock file updates only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants