-
Notifications
You must be signed in to change notification settings - Fork 48
Add Django 5.x testing support #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Added PyCharm and system-specific files to .gitignore - Extended tox environments to cover Django 4.2, 5.0, 5.1, 5.2 alpha, and main branch - Ensured flake8 and isort checks are included in tox - Improved test matrix to run across Python 3.9–3.13
- Add Python environment and IDE-specific files - Exclude local development artifacts - Ensure clean repository structure
## Changes Made - Added Django 5.0, 5.1, 5.2, and main branch to test matrix - Included Python 3.10+ support for Django 5.x versions (requirement for Django 5.0+) - Updated GitHub Actions workflow to handle Django 5.2 alpha installations - Maintained backward compatibility with Django 4.2 and Python 3.9 - Added proper error handling for unstable Django main branch ## Test Matrix Coverage - **Django 4.2**: Python 3.9, 3.10, 3.11, 3.12 - **Django 5.0**: Python 3.10, 3.11, 3.12, 3.13 - **Django 5.1**: Python 3.10, 3.11, 3.12, 3.13 - **Django 5.2**: Python 3.10, 3.11, 3.12, 3.13 - **Django main**: Python 3.10, 3.11, 3.12, 3.13 (with error tolerance) Tested locally with `tox -e py310-dj51` and `tox -e py312-dj52`.
- Add Django 5.0, 5.1, 5.2, and main branch to test matrix - Include Python 3.10+ support for Django 5.x compatibility - Update GitHub Actions workflow for Django 5.2 alpha handling - Maintain backward compatibility with Django 4.2 and Python 3.9 - Add proper error handling for unstable Django main branch Fixes django-cms#132
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 9 9
Lines 537 537
Branches 76 76
======================================
Misses 537 537 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@g-builder-0 Thanks for the PR! I think current Django main only works with python 3.11+. Can you adjust the test matrix? |
Thanks for pointing that out! I will update the test matrix. |
2f46dd3 to
d5223ed
Compare
|
@g-builder-0 It seems I got it wrong: Django 6 starts at Python 3.12. Sorry. |
Django 6 (main branch) requires Python 3.12+ minimum. Updated both tox.ini and GitHub Actions matrix accordingly. - Remove Python 3.11 from Django main testing - Maintain Python 3.10+ support for Django 5.0-5.2 - Keep backward compatibility for Django 4.2 Addresses maintainer feedback in PR review.
fsbraun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Add Django 5.x testing support
Fixes #132
Summary
This PR adds comprehensive testing support for Django 5.0, 5.1, 5.2, and the main development branch as requested in issue #132.
Changes Made
tox.ini.github/workflows/test.ymlTest Matrix Coverage
Testing
Tested locally with:
Compatibility Notes
masterSlack to find a “pr review buddy” who is going to review my pull request.